Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly set php version to be used during CI build #1595

Merged
merged 2 commits into from
Sep 21, 2023
Merged

Conversation

balsama
Copy link
Contributor

@balsama balsama commented Sep 21, 2023

Motivation
There were a couple of changes in shivammathur/setup-php (specifically #754) which resulted in new builds using PHP 8.0 during the build step.

Proposed changes
This change explicitly sets the php version to be used.

Alternatives considered
None

Testing steps
The build step will fail (example) without this with:

"Error: ] Your system is not ready to run the application.                       
                                                                                

Fix the following mandatory requirements:
=========================================

 * The application requires a version matching "^8.1"."

And it will pass with this PR merged.

@balsama balsama changed the title Explicitely set php version to be used during CI build Explicitly set php version to be used during CI build Sep 21, 2023
@balsama balsama added the chore label Sep 21, 2023
@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (2691e56) 91.76% compared to head (e2f6b4e) 91.76%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1595   +/-   ##
=========================================
  Coverage     91.76%   91.76%           
  Complexity     1809     1809           
=========================================
  Files           124      124           
  Lines          6471     6471           
=========================================
  Hits           5938     5938           
  Misses          533      533           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@balsama balsama merged commit 471793e into main Sep 21, 2023
21 of 22 checks passed
@danepowell
Copy link
Contributor

Thanks. I was initially confused by this report because Acquia CLI itself only requires PHP 8.0. But the Box compiler requires PHP 8.1; that's what was throwing the error when the setup-php action changed and started running PHP 8.0.

This seems like the best solution, short of a separate PHP version for require and require-dev, which is a whole other kettle of fish: composer/composer#5136

@danepowell danepowell deleted the set-php-version branch February 23, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants