Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New command: app:new:from:drupal7 #1543

Merged
merged 34 commits into from
Aug 10, 2023
Merged

New command: app:new:from:drupal7 #1543

merged 34 commits into from
Aug 10, 2023

Commits on Jun 15, 2023

  1. Copy over the "inspect Drupal 7" source code from AMA.

    @wimleers
    Gabe Sullice authored and wimleers committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    05b72ee View commit details
    Browse the repository at this point in the history

  2. Adjust namespaces.

    @wimleers
    wimleers committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    5d00739 View commit details
    Browse the repository at this point in the history

  3. Mark this namespace as not needing autowiring.

    @wimleers
    wimleers committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    c1686f6 View commit details
    Browse the repository at this point in the history

  4. Copy over the "recommendations and how to generate a Drupal 9+ projec… 

    …t from it" source code from AMA.
    @wimleers
    Gabe Sullice authored and wimleers committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    d9d2b7b View commit details
    Browse the repository at this point in the history

  5. Adjust namespaces.

    @wimleers
    wimleers committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    aca3ba3 View commit details
    Browse the repository at this point in the history

  6. Adjust for stricter phpcs configuration. Loving the removal of so m… 

    …uch boilerplate! 😄
    @wimleers
    wimleers committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    3b2dc98 View commit details
    Browse the repository at this point in the history

  7. Add new app:new:from:drupal7 command. Include default config.json… 

    … and `recommendations.json`.
    @wimleers
    wimleers committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    e37555a View commit details
    Browse the repository at this point in the history

  8. Copy over the unit tests from AMA.

    @wimleers
    Gabe Sullice authored and wimleers committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    a9c7307 View commit details
    Browse the repository at this point in the history

  9. Adjust namespaces.

    @wimleers
    wimleers committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    91e0c8f View commit details
    Browse the repository at this point in the history

  10. Adjust for stricter phpcs configuration. Loving the removal of so m… 

    …uch boilerplate, AGAIN! 😄
    @wimleers
    wimleers committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    7919758 View commit details
    Browse the repository at this point in the history

  11. composer require --dev phpspec/prophecy-phpunit ^2.0

    @wimleers
    wimleers committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    32ad92e View commit details
    Browse the repository at this point in the history

  12. Copy over the integration tests' fixtures + infrastructure from AMA.

    @wimleers
    Gabe Sullice authored and wimleers committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    bfcfccc View commit details
    Browse the repository at this point in the history

  13. Adjust for stricter phpcs configuration.

    @wimleers
    wimleers committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    fc6d16e View commit details
    Browse the repository at this point in the history

  14. Expand the default recommendations to allow upcoming integration test… 

    …s to actually test the full range of possibilities.
    @wimleers
    wimleers committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    0cedae0 View commit details
    Browse the repository at this point in the history

  15. Allow tests to override the inspector used, because setting up a real… 

    … Drupal 7 instance is impractical in tests.
    @wimleers
    wimleers committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    c18efc3 View commit details
    Browse the repository at this point in the history

  16. The VERSION constant can only be made available if it is possible t… 

    …o bootstrap Drupal 7. That cannot happen int ests, so adjust the logic in `NewFromDrupal7Command` slightly.
    @wimleers
    wimleers committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    733b5c5 View commit details
    Browse the repository at this point in the history

  17. Integration test for app:new:from:drupal7 command, tested on 4 diff… 

    …erent Drupal 7 sites 👍
    @wimleers
    wimleers committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    f14401a View commit details
    Browse the repository at this point in the history

  18. Adjust expectations of KernelTest to expect one new entry in `acli … 

    …list`.
    @wimleers
    wimleers committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    d209483 View commit details
    Browse the repository at this point in the history

  19. phpstan

    @wimleers
    wimleers committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    e1385da View commit details
    Browse the repository at this point in the history

  20. Ignore Drupal7SiteInspector in code coverage checks.

    @wimleers
    wimleers committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    5ec7893 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2023

  1. Add a silly unit test just to make codecov happy 🤷‍♂️

    @wimleers
    wimleers committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    11abf52 View commit details
    Browse the repository at this point in the history

  2. Allow specifying --recommendations.

    @wimleers
    wimleers committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    c656169 View commit details
    Browse the repository at this point in the history

  3. Copy over the path processing from AMA.

    @wimleers
    wimleers committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    d8034fe View commit details
    Browse the repository at this point in the history

  4. Allow specifying --stored-analysis, this removes the need for using… 

    … reflection in the integration test.
    @wimleers
    wimleers committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    987ce00 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2023

  1. phpunit expects @covers annotations to have differently shaped va… 

    …lues.
    @wimleers
    wimleers committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    9a0814b View commit details
    Browse the repository at this point in the history

  2. Increase NewFromDrupal7Command code coverage by explicitly specifyi… 

    …ng `--recommendations`.
    @wimleers
    wimleers committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    e22a60b View commit details
    Browse the repository at this point in the history

  3. Move two static helper methods from NewFromDrupal7Command to `Dru… 

    …pal7SiteInspector` to increase the reported code coverage; these only operate on live Drupal 7 sites so are by definition untestable.
    @wimleers
    wimleers committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    7d88c51 View commit details
    Browse the repository at this point in the history

  4. Attempt to make this pass on Windows.

    @wimleers
    wimleers committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    a694e0e View commit details
    Browse the repository at this point in the history

  5. strpos($location, "/") === 0 is not a valid way to detect absolute … 

    …paths on Windows: it fails on `D:/a/cli/cli/config/…`.
    @wimleers
    wimleers committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    da056f6 View commit details
    Browse the repository at this point in the history

  6. Remove pointless if-test.

    @wimleers
    wimleers committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    74f9f70 View commit details
    Browse the repository at this point in the history

  7. Kill 2 more mutants by using PHP named arguments.

    @wimleers
    wimleers committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    e9ba9af View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2023

  1. \Symfony\Component\Console\Input\InputInterface::hasOption() cannot… 

    … be trusted.
    @wimleers
    wimleers committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    a9c042e View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2023

  1. Merge branch 'main' into app-new-from-drupal7

    @wimleers
    wimleers committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    efc6df3 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2023

  1. Merge branch 'main' into app-new-from-drupal7

    @danepowell
    danepowell committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    c214e45 View commit details
    Browse the repository at this point in the history