fix tests

acquia · Sep 9, 2024 · c695155 · c695155
1 parent 448077e
commit c695155
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 3 deletions.
diff --git a/src/Command/CommandBase.php b/src/Command/CommandBase.php
@@ -1197,6 +1197,9 @@ public function checkForNewVersion(): bool|string
         if (AcquiaDrupalEnvironmentDetector::isAhIdeEnv()) {
             return false;
         }
+        if ($this->getApplication()->getVersion() === 'dev-unknown') {
+            return false;
+        }
         try {
             if (!$this->selfUpdateManager->isUpToDate()) {
                 return $this->selfUpdateManager->getLatestReleaseFromGithub()['tag_name'];

diff --git a/tests/phpunit/src/Application/KernelTest.php b/tests/phpunit/src/Application/KernelTest.php
@@ -26,7 +26,7 @@ public function testRun(): void
     private function getStart(): string
     {
         return <<<EOD
-Acquia CLI
+Acquia CLI dev-unknown
 
 Usage:
   command [options] [arguments]

diff --git a/tests/phpunit/src/ApplicationTestBase.php b/tests/phpunit/src/ApplicationTestBase.php
@@ -36,7 +36,7 @@ public function setUp(): void
     protected function runApp(): string
     {
         putenv("ACLI_REPO_ROOT=" . $this->projectDir);
-        putenv("ACLI_VERSION=" . 'UNKNOWN');
+        putenv("ACLI_VERSION=" . 'dev-unknown');
         $input = $this->kernel->getContainer()->get(InputInterface::class);
         $output = $this->kernel->getContainer()->get(OutputInterface::class);
         /** @var Application $application */

diff --git a/tests/phpunit/src/TestBase.php b/tests/phpunit/src/TestBase.php
@@ -178,7 +178,9 @@ protected function setUp(): void
         $this->consoleOutput = new ConsoleOutput();
         $this->setClientProphecies();
         $this->setIo();
-        $this->selfUpdateManager = $this->prophet->prophesize(SelfUpdateManager::class)->reveal();
+        $selfUpdateManagerProphecy = $this->prophet->prophesize(SelfUpdateManager::class);
+        $selfUpdateManagerProphecy->isUpToDate()->willReturn(true);
+        $this->selfUpdateManager = $selfUpdateManagerProphecy->reveal();
 
         $this->vfsRoot = vfsStream::setup();
         $this->projectDir = vfsStream::newDirectory('project')