Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACMS-4210: Removing google_analytics. #1877

Merged
merged 3 commits into from
Sep 19, 2024
Merged

ACMS-4210: Removing google_analytics. #1877

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
250b79f
ACMS-4210: Removing google_analytics.
apathak18 Sep 12, 2024
0c5fe5e
ACMS-4210: Removing google_tag too.
apathak18 Sep 18, 2024
b062904
Removed google_tag as it's not added in tour yet.
vishalkhode1 Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
"drupal/acquia_cms_tour": "dev-develop",
"drupal/consumer_image_styles": "^4.0",
"drupal/gin": "^3.0@RC",
"drupal/google_analytics": "dev-3430780-automated-drupal-11",
"drupal/google_tag": "^2.0",
"drupal/honeypot": "^2.1",
"drupal/recaptcha": "^3.2",
Expand Down Expand Up @@ -237,10 +236,6 @@
"type": "vcs",
"url": "https://git.drupalcode.org/issue/consumer_image_styles-3429496.git"
},
"google_analytics": {
"type": "vcs",
"url": "https://git.drupalcode.org/issue/google_analytics-3430780.git"
},
"config_filter": {
"type": "vcs",
"url": "https://git.drupalcode.org/issue/config_filter-3428542.git"
Expand Down
47 changes: 5 additions & 42 deletions composer.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion modules/acquia_cms_tour/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
},
"require-dev": {
"drupal/acquia_cms_place": "^1",
"drupal/google_analytics": "dev-3430780-automated-drupal-11",
"drupal/recaptcha": "^3"
},
"config": {
Expand Down
2 changes: 1 addition & 1 deletion modules/acquia_cms_tour/src/Controller/DashboardController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ public function content() {
$form['help_text'] = [
'#type' => 'markup',
'#markup' => $this->t("<i><h3>It seems like you have installed minimal Acquia CMS, which does not have any specific configurations. You are all set. Once you enable any of the modules supported by the wizard, they should start appearing here.
(ex. google_analytics, gecoder, recaptcha, cohesion etc.).</h3></i>"),
(ex. gecoder, recaptcha, cohesion etc.).</h3></i>"),
];
}
$form['check_total']['#value'] = $total;
Expand Down
139 changes: 0 additions & 139 deletions modules/acquia_cms_tour/src/Plugin/AcquiaCmsTour/GoogleAnalyticsForm.php
View file
Open in desktop

This file was deleted.

81 changes: 0 additions & 81 deletions modules/acquia_cms_tour/tests/src/Functional/GoogleAnalyticsTest.php
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion modules/acquia_cms_tour/tests/src/Kernel/AcquiaTourDashboardTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ class AcquiaTourDashboardTest extends KernelTestBase {
public function testAcquiaCmsTourPlugin() {
$expected_plugin_order = [
'geocoder',
'google_analytics',
'google_tag',
'recaptcha',
];
Expand Down
Loading