Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACMS-4210: Removing google_analytics. #1874

Closed
wants to merge 56 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
56 commits
Select commit Hold shift + click to select a range
a36b6a0
ACMS-3923: Drupal 11 compatibility fixes for ACMS Event.
rajeshreeputra Jun 13, 2024
caaeed9
ACMS-3927: Drupal 11 compatibility fixes for ACMS Place.
rajeshreeputra Jun 13, 2024
65ad296
ACMS-3924: Drupal 11 compatibility fixes for ACMS Image.
rajeshreeputra Jun 7, 2024
31336c0
ACMS-3925: Drupal 11 compatibility fixes for ACMS Page.
rajeshreeputra Jun 21, 2024
a9bfd1d
ACMS-3926: Drupal 11 compatibility fixes for ACMS Person.
rajeshreeputra Jun 20, 2024
4c3f6e2
ACMS-3919: Drupal 11 compatibility fixes for ACMS Audio.
rajeshreeputra Jun 19, 2024
5281634
ACMS-3922: Drupal 11 compatibility fixes for ACMS Document.
rajeshreeputra Jun 20, 2024
f8fa24f
ACMS-3920: Drupal 11 compatibility core version requirement changes f…
rajeshreeputra Jun 7, 2024
29d9d0a
ACMS-3920: Drupal 11 compatibility deprecation fixes for ACMS Common.
rajeshreeputra Jun 7, 2024
fe9480d
ACMS-3920: Remove unused deprecation helper.
rajeshreeputra Jun 19, 2024
6d4f2c6
ACMS-3920: Refactor permissions tests.
rajeshreeputra Jun 24, 2024
4503741
ACMS-3920: Make provider method static.
rajeshreeputra Jun 24, 2024
3a6e5f5
ACMS-3920: Fix phpstan error for method.
chandan-singh7929 Jun 25, 2024
ab32ce5
ACMS-3920: Fixed failing PHPStan errors for ACMS Site Studio and Exis…
vishalkhode1 Jun 25, 2024
0060683
ACMS-3920: Provide string param to static object of EntityPermissinsT…
rajeshreeputra Jun 25, 2024
95e703c
ACMS-3920: Make existingsite tests provider method static.
rajeshreeputra Jun 25, 2024
cd83122
ACMS-3918: Drupal 11 compatibility fixes for ACMS Article.
rajeshreeputra Jun 25, 2024
4a03218
ACMS-3928: D11 upgrade Acquia CMS Search.
chandan-singh7929 Jun 26, 2024
408d98d
ACMS-3932: Drupal 11 compatibility fixes for ACMS Video.
rajeshreeputra Jun 20, 2024
d87a6c3
ACMS-3931: Adding D11 version.
apathak18 Jun 26, 2024
b3b6332
ACMS-3931: Avoiding direct drupal call.
apathak18 Jun 28, 2024
2e47f60
Update as per PR feedback.
apathak18 Jul 2, 2024
392f9e7
ACMS-3921: D11 upgrade Acquia CMS DAM.
chandan-singh7929 Jun 25, 2024
ca19618
ACMS-3930: Drupal 11 compatibility fixes for ACMS Toolbar.
rajeshreeputra Jul 3, 2024
2a2217e
ACMS-4045: Drupal 11 compatibility fixes for ACMS Starter.
rajeshreeputra Jul 8, 2024
ac2cb9f
ACMS-4042: D11 upgrade Acquia CMS Component.
chandan-singh7929 Jul 17, 2024
758b563
ACMS-4042: Update component as per 10.3 requirement.
chandan-singh7929 Jul 17, 2024
26cf065
ACMS-4044: Initial changes for D11 Acquia cms headless.
apathak18 Jul 23, 2024
3f4d731
Adding static to dataProviders.
apathak18 Jul 26, 2024
ac85169
ACMS-4044: Removing subrequests patch.
apathak18 Jul 27, 2024
c02d551
ACMS-3929: Update sietstudio to 8.0.0 version.
rajeshreeputra Jul 31, 2024
64babdf
ACMS-3947: Drupal 11 compatibility fixes for SiteStudio Config Manage…
rajeshreeputra Jul 31, 2024
6b4631e
ACMS-3929: Drupal 11 compatibility fixes for ACMS SiteStudio.
rajeshreeputra Jul 31, 2024
37ab9c0
ACMS-3929: Update ACMS Config Importer service.
rajeshreeputra Aug 5, 2024
6f5c510
ACMS-3929: Update packages to latest version.
rajeshreeputra Aug 5, 2024
3542721
ACMS-3929: Update workflow to run test against previous major i.e. 10…
rajeshreeputra Aug 5, 2024
7a42109
ACMS-3929: Remove openapi_jsonapi patch.
rajeshreeputra Aug 5, 2024
f53704c
ACMS-3929: Run ci with INTEGRATED_TEST_ON_LATEST_LTS.
rajeshreeputra Aug 5, 2024
356be98
ACMS-4173: Fix failing tests.
rajeshreeputra Aug 30, 2024
e8b8e9e
ACMS-4173: verify D11 compatibility.
rajeshreeputra Aug 29, 2024
7a52312
ACMS-4173: update package versions.
rajeshreeputra Aug 29, 2024
704f3bd
ACMS-4173: Fix failing tests.
rajeshreeputra Aug 30, 2024
d7eb6e1
ACMS-4173: Update before install to run other CI jobs.
rajeshreeputra Aug 30, 2024
94a1b7e
ACMS-4173: Add moderation dashboard patch for default_argument_skip_u…
rajeshreeputra Sep 2, 2024
f96de0c
ACMS-4173: Fix provide is not static failure.
rajeshreeputra Sep 2, 2024
8a738a3
ACMS-4173: Update Acquia DAM with vcs path to use cohesion 8.x versio…
rajeshreeputra Sep 3, 2024
89d5232
ACMS-4173: update packages to latest version.
rajeshreeputra Sep 6, 2024
8f69133
ACMS-4173: Update the backstop tests LTS version.
rajeshreeputra Sep 9, 2024
fa51795
ACMS-4173: skip headless in drupal-check.
rajeshreeputra Sep 9, 2024
6996719
ACMS-4173: run backstop tests with D10.
rajeshreeputra Sep 9, 2024
cb8b397
ACMS-4173: Run existing site tests.
rajeshreeputra Sep 10, 2024
f40399b
ACMS-4173: fix existing site tests.
rajeshreeputra Sep 10, 2024
cfcd9d2
ACMS-4173: "Reverted composer patch failure variable from root compos…
apathak18 Sep 11, 2024
07774b3
ACMS-4173: Updating with composer normalize.
apathak18 Sep 11, 2024
f4a79bc
Merge pull request #1868 from acquia/ACMS-4173
vishalkhode1 Sep 11, 2024
e48b869
ACMS-4210: Removing google_analytics.
apathak18 Sep 12, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 45 additions & 10 deletions .github/workflows/acquia_cms_ci.workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -93,13 +93,20 @@ jobs:
#coverage: xdebug
- name: Execute PHPStan
run: |
# Remove Acquia CMS modules.
# @todo: Remove module from below which you want to make Drupal 11 compatible.
composer remove "drupal/acquia_cms_headless" --no-install --no-update
# Remove acquia_cms_headless module.
rm -fr modules/acquia_cms_headless
# Unset the repository path.
composer config repositories.acquia_cms_headless --unset
rm composer.lock
composer install
./vendor/bin/phpstan analyze
integrated_tests:
if: ${{ github.event_name == 'pull_request' }}
name: ${{ matrix.acms_job }} (${{ matrix.orca-job }})
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
env:
# Site test artifacts.
# ACMS_DB_ARTIFACT: "/home/runner/work/acquia_cms/acquia_cms/tests/acms.sql.gz"
Expand Down Expand Up @@ -131,6 +138,7 @@ jobs:
fail-fast: false
matrix:
orca-job:
- INTEGRATED_TEST_ON_LATEST_LTS
- ISOLATED_TEST_ON_CURRENT
acms_job:
- integrated_php_unit_tests
Expand Down Expand Up @@ -163,6 +171,13 @@ jobs:
# aws-region: ${{ secrets.AWS_DEFAULT_REGION }}
- name: Before Install
run: |
# Remove Acquia CMS modules.
# @todo: Remove module from below which you want to make Drupal 11 compatible.
composer remove "drupal/acquia_cms_headless" --no-install --no-update
# Remove acquia_cms_headless module.
rm -fr modules/acquia_cms_headless
# Unset the repository path.
composer config repositories.acquia_cms_headless --unset
# Update the CI by adding patches without pinning the following modules.
#composer require "drupal/facets:^2.0.6" --no-update --no-install -d modules/acquia_cms_search

Expand Down Expand Up @@ -200,8 +215,8 @@ jobs:
../orca/bin/ci/after_script.sh
isolated_tests:
if: ${{ github.event_name == 'pull_request' }}
name: acquia_cms (${{ matrix.modules }})
runs-on: ubuntu-latest
name: acquia_cms (${{ matrix.modules }}) on (${{ matrix.orca-job }})
runs-on: ubuntu-24.04
env:
# Set ORCA related environment variables.
ORCA_SUT_NAME: acquia/acquia_cms
Expand Down Expand Up @@ -230,6 +245,7 @@ jobs:
fail-fast: false
matrix:
orca-job:
- INTEGRATED_TEST_ON_LATEST_LTS
- ISOLATED_TEST_ON_CURRENT
#php-version: [ "8.1" ]
modules:
Expand All @@ -238,16 +254,16 @@ jobs:
- acquia_cms_common
- acquia_cms_document
- acquia_cms_event
- acquia_cms_headless
# - acquia_cms_headless
- acquia_cms_image
- acquia_cms_page
- acquia_cms_person
- acquia_cms_place
- acquia_cms_search
- acquia_cms_site_studio
# - acquia_cms_site_studio
- acquia_cms_tour
- acquia_cms_video
- sitestudio_config_management
# - sitestudio_config_management
steps:
- uses: actions/checkout@v3
- name: Use Node.js 12.13.1
Expand All @@ -265,6 +281,13 @@ jobs:
curl https://gist.githubusercontent.com/rajeshreeputra/170586f217b422eb9cdfd9ca9457a2e3/raw/c2f277ba9005b91d7f662cacf37b3940a66a9b8c/sut-path-reposories.patch | git -C ../orca apply
- name: Before Install
run: |
# Remove Acquia CMS modules.
# @todo: Remove module from below which you want to make Drupal 11 compatible.
composer remove "drupal/acquia_cms_headless" --no-install --no-update
# Remove acquia_cms_headless module.
rm -fr modules/acquia_cms_headless
# Unset the repository path.
composer config repositories.acquia_cms_headless --unset
# Remove all ExistingSite test in CI.
find tests/src -type f -name "*Test.php" -path "*/ExistingSite*/*" -exec rm -fr '{}' ';'
# Remove all PHPUnit test files, excluding the current module's PHPUnit tests.
Expand Down Expand Up @@ -326,11 +349,15 @@ jobs:
fail-fast: false
matrix:
orca-job:
- INTEGRATED_TEST_ON_PREVIOUS_MINOR
- INTEGRATED_TEST_ON_LATEST_LTS
# - INTEGRATED_TEST_ON_PREVIOUS_MINOR
- ISOLATED_TEST_ON_CURRENT
php-version:
- 8.1
- 8.3
exclude:
- php-version: 8.1
orca-job: ISOLATED_TEST_ON_CURRENT
steps:
- uses: actions/checkout@v4
- name: Use Node.js 20.x
Expand All @@ -350,7 +377,8 @@ jobs:
composer self-update
composer create-project --no-dev --ignore-platform-req=php acquia/orca ../orca "$ORCA_VERSION" -n
curl https://gist.githubusercontent.com/rajeshreeputra/170586f217b422eb9cdfd9ca9457a2e3/raw/c2f277ba9005b91d7f662cacf37b3940a66a9b8c/sut-path-reposories.patch | git -C ../orca apply
curl https://gist.githubusercontent.com/vishalkhode1/342a0eee801e51f48b4d9701749c1c94/raw/orca-oldest-support.patch | git -C ../orca apply
# Remove Drupal core 9.5.x as oldest support in favor of 10.3.x
# curl https://gist.githubusercontent.com/vishalkhode1/342a0eee801e51f48b4d9701749c1c94/raw/orca-oldest-support.patch | git -C ../orca apply
- name: Configure AWS Credentials
uses: aws-actions/configure-aws-credentials@v1
with:
Expand All @@ -359,9 +387,16 @@ jobs:
aws-region: ${{ secrets.AWS_DEFAULT_REGION }}
- name: Before Install
run: |
# Remove Acquia CMS modules.
# @todo: Remove module from below which you want to make Drupal 11 compatible.
composer remove "drupal/acquia_cms_headless" --no-install --no-update
# Remove acquia_cms_headless module.
rm -fr modules/acquia_cms_headless
# Unset the repository path.
composer config repositories.acquia_cms_headless --unset
# Added below in CI to test acquia_cms on Drupal Core >=9.5.
composer require "drupal/core:>=9.5" --no-update --no-install -d modules/acquia_cms_common
sed -i 's/^core_version_requirement.*/core_version_requirement: ">=9.5"/' modules/acquia_cms_common/acquia_cms_common.info.yml
# composer require "drupal/core:>=9.5" --no-update --no-install -d modules/acquia_cms_common
# sed -i 's/^core_version_requirement.*/core_version_requirement: ">=9.5"/' modules/acquia_cms_common/acquia_cms_common.info.yml

# Remove all PHPunit tests from acquia_cms modules.
find modules/*/tests tests/src -type f -name "*Test.php" -exec rm -fr '{}' ';'
Expand Down
33 changes: 22 additions & 11 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,34 +21,31 @@
"drupal/acquia_cms_audio": "dev-develop",
"drupal/acquia_cms_component": "dev-develop",
"drupal/acquia_cms_dam": "dev-develop",
"drupal/acquia_cms_headless": "dev-develop",
"drupal/acquia_cms_site_studio": "dev-develop",
"drupal/acquia_cms_starter": "dev-develop",
"drupal/acquia_cms_toolbar": "dev-develop",
"drupal/acquia_cms_tour": "dev-develop",
"drupal/consumer_image_styles": "^4.0",
"drupal/gin": "^3.0@RC",
"drupal/google_analytics": "^4.0",
"drupal/google_tag": "^2.0",
"drupal/honeypot": "^2.1",
"drupal/recaptcha": "^3.2",
"drupal/reroute_email": "^2.2",
"drupal/shield": "^1.7",
"drupal/sitestudio_config_management": "dev-develop",
"drupal/sitestudio_gin": "^1.0",
"drush/drush": "^10 || ^11 || ^12",
"drupal/sitestudio_gin": "dev-3434617-automated-drupal-11",
"drush/drush": "^10 || ^11 || ^12 || ^13",
"mnsami/composer-custom-directory-installer": "^2.0"
},
"require-dev": {
"acquia/coding-standards": "^1.0",
"axelerant/drupal-quality-checker": "~1.3.0",
"drupal/core-composer-scaffold": "^9.0.0 || ^10",
"drupal/core-dev": "^9 || ^10",
"drupal/core-composer-scaffold": "^10 || ^11",
"drupal/core-dev": "^10 || ^11",
"ergebnis/composer-normalize": "^2.31.0",
"mglaman/drupal-check": "^1.4",
"oomphinc/composer-installers-extender": "^1.1 || ^2",
"phpspec/prophecy-phpunit": "^2.0",
"phpunit/phpunit": "^9.4.0",
"phpunit/phpunit": "^9.4.0 || ^10",
"weitzman/drupal-test-traits": "^2"
},
"repositories": {
Expand Down Expand Up @@ -235,6 +232,22 @@
}
}
},
"acquia_dam": {
"type": "vcs",
"url": "https://git.drupalcode.org/issue/acquia_dam-3471717.git"
},
"consumer_image_styles": {
"type": "vcs",
"url": "https://git.drupalcode.org/issue/consumer_image_styles-3429496.git"
},
"config_filter": {
"type": "vcs",
"url": "https://git.drupalcode.org/issue/config_filter-3428542.git"
},
"sitestudio_gin": {
"type": "vcs",
"url": "https://git.drupalcode.org/issue/sitestudio_gin-3434617.git"
},
"drupal": {
"type": "composer",
"url": "https://packages.drupal.org/8"
Expand All @@ -257,6 +270,7 @@
"cweagans/composer-patches": true,
"dealerdirect/phpcodesniffer-composer-installer": true,
"drupal/core-composer-scaffold": true,
"drupal/core-project-message": true,
"ergebnis/composer-normalize": true,
"mnsami/composer-custom-directory-installer": true,
"oomphinc/composer-installers-extender": true,
Expand Down Expand Up @@ -338,9 +352,6 @@
"3111456 - Unable to resolve path on node in other language than default": "https://www.drupal.org/files/issues/2024-07-11/decouple_router-3111456-resolve-language-issue-63--get-translation-re-rolled.patch",
"3176615 - RouteNotFoundException when a jsonapi individual route is not available": "https://gist.githubusercontent.com/vishalkhode1/aff30a9a82b895ce6071a0f71be2a5ba/raw/3176615-route-not-found-exception.patch"
},
"drupal/openapi_jsonapi": {
"Fixed the fatal error appearing due to changes in openapi module": "https://gist.githubusercontent.com/vishalkhode1/d904011f3a69aa71fa2c06219b077983/raw/fix-openapi-jsonapi-module.patch"
},
"mglaman/drupal-check": {
"Add custom rules to bypass check for buildForm": "https://github.com/mglaman/drupal-check/pull/286.patch"
}
Expand Down
Loading
Loading