-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ACMS-4173: verify D11 compatibility. #1868
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajeshreeputra
force-pushed
the
ACMS-4173
branch
4 times, most recently
from
August 30, 2024 07:59
f6c2511
to
17f74ef
Compare
apathak18
reviewed
Aug 30, 2024
modules/acquia_cms_common/tests/src/Functional/BasicPermissionsTest.php
Outdated
Show resolved
Hide resolved
rajeshreeputra
force-pushed
the
drupal11-readiness
branch
from
August 30, 2024 12:35
c847c87
to
356be98
Compare
rajeshreeputra
force-pushed
the
ACMS-4173
branch
from
September 2, 2024 04:28
17f74ef
to
d7eb6e1
Compare
…rl missing schema error.
rajeshreeputra
force-pushed
the
ACMS-4173
branch
from
September 6, 2024 13:09
38385ba
to
89d5232
Compare
rajeshreeputra
requested review from
chandan-singh7929,
vishalkhode1 and
apathak18
September 9, 2024 04:50
rajeshreeputra
force-pushed
the
ACMS-4173
branch
from
September 9, 2024 11:52
6888752
to
6996719
Compare
rajeshreeputra
force-pushed
the
ACMS-4173
branch
2 times, most recently
from
September 10, 2024 09:31
1844079
to
f0657f7
Compare
rajeshreeputra
force-pushed
the
ACMS-4173
branch
from
September 10, 2024 10:31
f0657f7
to
f40399b
Compare
chandan-singh7929
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall changes looks good to me.
apathak18
reviewed
Sep 10, 2024
apathak18
reviewed
Sep 10, 2024
apathak18
approved these changes
Sep 11, 2024
vishalkhode1
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #NNN
Proposed changes
Alternatives considered
Testing steps
Merge requirements