Email ics file for pickup events #443
Conversation
echang594
requested review from
sumeet-bansal,
shravanhariharan2,
dowhep and
nik-dange
as code owners
|
Thanks for contributing! |
There was a problem hiding this comment.
Looks great to me, a much appreciated feature! What are your thoughts on adding location as a column to OrderPickupEventModel? We now support linking regular events to pickup events, so maybe on the frontend if it's linked they can just fill in that location but if it's unlinked the user can input a location. This way we can show it in the calendar invite as well.
| @@ -903,6 +905,15 @@ export default class MerchStoreService { | |||
| }; | |||
| } | |||
|
|
|||
| private static toEventCalendarInfo(pickupEvent: OrderPickupEventModel): OrderPickupEventCalendarInfo { | |||
| return { | |||
| start: pickupEvent.start.getTime(), | |||
There was a problem hiding this comment.
What are your thoughts on adding location as a field to OrderPickupEvents?
There was a problem hiding this comment.
After discussing, we've decided to add it and copy over the location from the linkedEvent if none is provided. One potential issue is that if the linkedEvent location updates, this field will not, however, we do not think this will be a big problem as the user will be notified through discord.
Info
Closes #441.
Description
What changes did you make? List all distinct problems that this PR addresses. Explain any relevant
motivation or context.
Changes
Type of Change
expected)
workflows, linting, etc.)
If you've selected Patch, Minor, or Major as your change type, make sure to bump the version before merging in
package.json!Testing
I have tested that my changes fully resolve the linked issue ...
Checklist
package.jsonfile.Screenshots
Please include a screenshot of your Postman testing passing successfully.