Throw error on event creation if start date is later than end date #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxwn04
requested review from
sumeet-bansal,
shravanhariharan2 and
dowhep
as code owners
|
Thanks for contributing! If you've made changes to the API's functionality, please make sure to bump the package version—see this guide to semantic versioning for details—and document those changes as appropriate. |
dowhep
requested changes
Jun 28, 2023
dowhep
requested changes
Jul 5, 2023
dowhep
requested changes
Jul 6, 2023
|
|
dowhep
requested changes
Oct 4, 2023
dowhep
requested changes
Oct 14, 2023
nick-ls
pushed a commit
to nick-ls/membership-portal
that referenced
this pull request
Aug 6, 2024
…cmucsd#355) * Throw error on event creation if start date is later than end date * Test for create event with invalid date * Remove unused imports, add trailing commas, add missing semi-colon * Remove unecessary quotes * Add EOL at end * Add event testers for success and duplicate code case * fix linter issues * Permissions test for event creation * Added event creation into repo check. Some Comments * linter error fix * more linter * last check * bugfix * check event lookup * fix services: * lint * more lint * lint fix * fix moment * boolean fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added condition in the create function for the event service to check if the end date was later than the start date
Closes #179.