Create Multiple Gallery Store Images #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dowhep
requested review from
sumeet-bansal and
shravanhariharan2
as code owners
|
Thanks for contributing! If you've made changes to the API's functionality, please make sure to bump the package version—see this guide to semantic versioning for details—and document those changes as appropriate. |
Comment on lines
2
to
3
|
|
||
| const TABLE_NAME = 'MerchItemImages'; |
There was a problem hiding this comment.
nit: let's call this table "MerchandiseItemPhotos". Since we use "Merchandise" instead of "Merch" for our other table names, we should stay consistent with that. And let's use "photos" instead of "images" since we are using the term "photos" for the environment variables to limit photo size:
… the frontend can display the first picture
* attendences from user uuid * lint and bugfix * check same user * controller factory changes * lint fixes * unit test for get attendance by uuid * lint * add permision * add types * add everything else * rename migrtion * test when permision is off * lint * forgor to add * change permission name and fix logic a bit * rename permission, change patch user * lint fix * lint fix * oops * check user exists * lint * new ci --------- Co-authored-by: Max Weng <[email protected]>
…into staging merging from master
models/OrderItemModel.ts
Outdated
| @@ -33,6 +33,7 @@ export class OrderItemModel extends BaseEntity { | |||
| notes: string; | |||
|
|
|||
| public getPublicOrderItem(): PublicOrderItem { | |||
| // console.log(this); | |||
nik-dange
approved these changes
Dec 31, 2023
|
IT HAPPENED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #339.