fixed bug for email array being out of order

acmucsd · Jul 8, 2023 · 25a19d1 · 25a19d1
1 parent d07b429
commit 25a19d1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/api/validators/AdminControllerRequests.ts b/api/validators/AdminControllerRequests.ts
@@ -66,4 +66,6 @@ export class ModifyUserAccessLevelRequest implements IModifyUserAccessLevelReque
   @IsDefined()
   @ArrayNotEmpty()
   accessUpdates: UserAccessUpdates[];
+
+
 }
diff --git a/services/UserAccountService.ts b/services/UserAccountService.ts
@@ -214,10 +214,11 @@ export default class UserAccountService {
         throw new BadRequestError(`Couldn't find accounts matching these emails: ${emailsNotFound}`);
       }
 
+
       const updatedUsers = await Promise.all(accessUpdates.map(async (accessUpdate, index) => {
         const { user, newAccess } = accessUpdate;
         const { accessType } = newAccess;
-        const currUser = users[index];
+        const currUser = await userRepository.findByEmail(user);
         // Prevent anyone from promoting user to admin
         if (accessType === UserAccessType.ADMIN) {
           throw new ForbiddenError('You cannot promote users to admin.');