responsive navbar #215
Merged
responsive navbar #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/acmucsd/main-website/9vudr79Bq3FAetschTCbo3doEjSm |
duanwilliam
reviewed
Feb 27, 2022
Comment on lines
+57
to
+58
| <div className={`${s.bar1} ${menuOpen && s.open}`} /> | ||
| <div className={`${s.bar2} ${menuOpen && s.open}`} /> |
There was a problem hiding this comment.
imo probably semantically better to use an inline svg and animate that
There was a problem hiding this comment.
i tried to do this and nothing would work so i'm going to ignore for now unless anyone thinks its significant enough
trulyronak
suggested changes
Feb 28, 2022
trulyronak
approved these changes
Mar 1, 2022
farisashai
added a commit
that referenced
this pull request
Mar 1, 2022
* completed rough event card * possible fix * remove console log * fix padding (#213) * fix text colors for different orgs * responsive navbar (#215) * started responsive navbar * commit typing * finish navbar * move navbar styles to component level module * commit module typing * use proper color variables * use seconds for transitions * fix navlink order * fix easing functions * add css comments * Fetch data for board cards at build time server-side (#211) * fetch board data from spreadsheet and populate * moved code to api util function * isr generate date once a day * delete hardcoded data * fixed board card fetch * fixes * Update BoardAPI.ts * dumb fix * Update Navbar.module.scss (#216) * fix navbar with events tab * optional facebook url
farisashai
added a commit
that referenced
this pull request
Mar 9, 2022
* completed rough event card * possible fix * remove console log * fix padding (#213) * fix text colors for different orgs * responsive navbar (#215) * started responsive navbar * commit typing * finish navbar * move navbar styles to component level module * commit module typing * use proper color variables * use seconds for transitions * fix navlink order * fix easing functions * add css comments * Fetch data for board cards at build time server-side (#211) * fetch board data from spreadsheet and populate * moved code to api util function * isr generate date once a day * delete hardcoded data * fixed board card fetch * fixes * Update BoardAPI.ts * dumb fix * Update Navbar.module.scss (#216) * fix navbar with events tab * optional facebook url * close on click (#218) * add event card filters * make footer icon type pointer hi ronak - chris * breakpoint as variable
farisashai
added a commit
that referenced
this pull request
Mar 25, 2022
* added route for events page * deleted everything * Events cards (#214) * completed rough event card * possible fix * remove console log * fix padding (#213) * fix text colors for different orgs * responsive navbar (#215) * started responsive navbar * commit typing * finish navbar * move navbar styles to component level module * commit module typing * use proper color variables * use seconds for transitions * fix navlink order * fix easing functions * add css comments * Fetch data for board cards at build time server-side (#211) * fetch board data from spreadsheet and populate * moved code to api util function * isr generate date once a day * delete hardcoded data * fixed board card fetch * fixes * Update BoardAPI.ts * dumb fix * Update Navbar.module.scss (#216) * fix navbar with events tab * optional facebook url * Event filters (#219) * completed rough event card * possible fix * remove console log * fix padding (#213) * fix text colors for different orgs * responsive navbar (#215) * started responsive navbar * commit typing * finish navbar * move navbar styles to component level module * commit module typing * use proper color variables * use seconds for transitions * fix navlink order * fix easing functions * add css comments * Fetch data for board cards at build time server-side (#211) * fetch board data from spreadsheet and populate * moved code to api util function * isr generate date once a day * delete hardcoded data * fixed board card fetch * fixes * Update BoardAPI.ts * dumb fix * Update Navbar.module.scss (#216) * fix navbar with events tab * optional facebook url * close on click (#218) * add event card filters * make footer icon type pointer hi ronak - chris * breakpoint as variable * remove old files * Event details (#220) * wire up dynamic routes from api and link from corresponding card * rename /event to /events * format event name in url * mobile at 960 * event page details + calendar actions * small fixes * fix committee name and css * remove unused link for now * fix replaceAll not supported * generate and cache paths server side * add support for viewing past events * fix some comments * SEO event link previews * pass entire event directly to event card * update seo description * mobile dropdown functioning * fix 2-way binding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rewrote Navbar component completely to simplify code structure for future maintainability, reduced re-renderings of ACM Logo, designed responsive mobile menu animation and hamburger icon opening/closing, changed background to white to match website theme, and moved Navbar code to Sass modules as part of our gradual move to Next.js
Type of change
How Has This Been Tested?
Checklist: