Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sponsors section #18

Merged
merged 2 commits into from
Dec 14, 2024
Merged

add sponsors section #18

merged 2 commits into from
Dec 14, 2024

Conversation

alexzhang1618
Copy link
Contributor

@alexzhang1618 alexzhang1618 commented Dec 10, 2024

Info

Closes #4

Screen.Recording.2024-12-10.at.2.36.05.PM.mov

Type of Change

  • Bug Fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • Logistics Change (A change to a README, description, or dev workflow setup like
    linting/formatting)
  • Continuous Integration Change (Related to deployment steps or continuous integration
    workflows)
  • Other: (Fill In)

Testing

I have tested that my changes fully resolve the linked issue ...

  • locally on Desktop.
  • on the live deployment preview on Desktop.
  • on the live deployment preview on Mobile.
  • I have added new Cypress tests that are passing.

Checklist

  • I have performed a self-review of my own code.
  • I have followed the style guidelines of this project.
  • I have documented any new functions in /src/lib/* and commented hard to understand areas
    anywhere else.
  • My changes produce no new warnings.

Copy link

vercel bot commented Dec 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
diamondhacks-teaser ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 10:39pm

Copy link
Member

@SheepTester SheepTester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

The button text wraps at this screen size (Android Chrome, desktop mode) for some reason. I'm not sure if this happens on real desktop or if it's just a weird thing with mobile browser desktop mode

Screenshot_20241210-152222

On mobile the sponsors cover the diamond

Screenshot_20241210-152237

@alexzhang1618
Copy link
Contributor Author

The button text wraps at this screen size (Android Chrome, desktop mode) for some reason.

Hm, I can't seem to repro, but I'll make the font sizes smaller for mobile so we won't run into this and it'll look better too

On mobile the sponsors cover the diamond

Yeah, styling for it is kinda rough, I think we can call it a feature, not a bug 😅

@alexzhang1618 alexzhang1618 merged commit ac671a7 into main Dec 14, 2024
4 checks passed
@alexzhang1618 alexzhang1618 deleted the alex/sponsors branch December 14, 2024 19:45
alexzhang1618 added a commit that referenced this pull request Dec 14, 2024
#18 hotfix: Add font scaling for sponsors section
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HomePage - Sponsors
2 participants