Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile hero #17

Merged
merged 6 commits into from
Dec 10, 2024
Merged

Mobile hero #17

merged 6 commits into from
Dec 10, 2024

Conversation

SheepTester
Copy link
Member

@SheepTester SheepTester commented Dec 10, 2024

Info

Closes #14

rearranged hero graphics for mobile, per design

Changes

  • split hero graphic into the peekers on the top and the jewel display below
  • changed hero on desktop to be a grid so that the elements can be reordered for mobile
  • unrelated, smaller changes:
    • the "hosted by ACM" text avoids wrapping in the middle of "ACM at UC San Diego"
    • hovering over the carousel pauses it if the user wants to study the image or smth

Type of Change

  • Bug Fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • Logistics Change (A change to a README, description, or dev workflow setup like
    linting/formatting)
  • Continuous Integration Change (Related to deployment steps or continuous integration
    workflows)
  • Other: (Fill In)

Testing

I have tested that my changes fully resolve the linked issue ...

  • locally on Desktop.
  • on the live deployment preview on Desktop.
  • on the live deployment preview on Mobile.
  • I have added new Cypress tests that are passing.

Checklist

  • I have performed a self-review of my own code.
  • I have followed the style guidelines of this project.
  • I have documented any new functions in /src/lib/* and commented hard to understand areas
    anywhere else.
  • My changes produce no new warnings.

Screenshots

Desktop Mobile
image image

Copy link

vercel bot commented Dec 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
diamondhacks-teaser ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 9:25am

also pause carousel on hover because why not
Copy link
Contributor

@alexzhang1618 alexzhang1618 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@alexzhang1618 alexzhang1618 merged commit 9299109 into main Dec 10, 2024
4 checks passed
@alexzhang1618 alexzhang1618 deleted the sean/omg-they-found-diamondhacks branch December 10, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hero: mobile view
2 participants