Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update installation script to handle errors and exit with the appropriate status code #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alexzhangs
Copy link

@alexzhangs alexzhangs commented May 8, 2024

@Neilpang @richard-vd After the change, the installer is able to exit with the curl's exit code.

$ sh index.html 
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (7) Failed to connect to raw.githubusercontent.com port 443 after 3 ms: Couldn't connect to server
$ echo $?
7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant