Refine the implementation of __clean_messages(). #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 15, 2018 23:09
- Suppress 'There were undefined references' unconditionally. The check that was done for it is inaccurate, as this message may also be printed when other types of things (citations, hyper references) are undefined. Even if we were to print it in corner cases, there would be nothing actionable. - Swallow warnings containing 'Rerun to get X right' and regarding undefined references when there are errors. We tend to generate a lot of them upon error, even though they are likely a result of LaTeX not completing in the first place.
This one is also preceded by more accurate warnings that refer to individual situations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suppress 'There were undefined references' unconditionally. The check
that was done for it is inaccurate, as this message may also be
printed when other types of things (citations, hyper references) are
undefined. Even if we were to print it in corner cases, there would be
nothing actionable.
Swallow warnings containing 'Rerun to get X right' and regarding
undefined references when there are errors. We tend to generate a lot
of them upon error, even though they are likely a result of LaTeX not
completing in the first place.