Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade libp2p to 0.51 #142

Merged
merged 11 commits into from
Aug 2, 2023
Merged

Upgrade libp2p to 0.51 #142

merged 11 commits into from
Aug 2, 2023

Conversation

ackintosh
Copy link
Owner

@ackintosh ackintosh commented Jun 22, 2023

TODO:

  • Fix warnings on build
  • Fix panics on runtime
    • thread 'ray' panicked at 'You must implement handle_established_inbound_connection and handle_established_outbound_connection.', /Users/akihito/.cargo/registry/src/index.crates.io-6f17d22bba15001f/libp2p-swarm-0.42.2/src/behaviour.rs:153:9

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clippy found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

src/identity.rs Fixed Show fixed Hide fixed
src/identity.rs Fixed Show fixed Hide fixed
src/main.rs Fixed Show fixed Hide fixed
src/rpc/behaviour.rs Fixed Show fixed Hide fixed
@ackintosh ackintosh marked this pull request as ready for review August 2, 2023 00:32
fn on_dial_failure(&self, peer_id: Option<PeerId>, dial_error: &DialError) {
if let Some(peer_id) = peer_id {
match dial_error {
DialError::Banned

Check warning

Code scanning / clippy

use of deprecated unit variant libp2p::libp2p_swarm::DialError::Banned: Use libp2p::allow_block_list instead. Warning

use of deprecated unit variant libp2p::libp2p\_swarm::DialError::Banned: Use libp2p::allow\_block\_list instead.
}
}
DialError::Aborted
| DialError::ConnectionLimit(_)

Check warning

Code scanning / clippy

use of deprecated tuple variant libp2p::libp2p_swarm::DialError::ConnectionLimit: Use libp2p::connection_limits instead and handle {Dial,Listen}Error::Denied::cause. Warning

use of deprecated tuple variant libp2p::libp2p\_swarm::DialError::ConnectionLimit: Use libp2p::connection\_limits instead and handle {Dial,Listen}Error::Denied::cause.
}
}
DialError::Aborted
| DialError::ConnectionLimit(_)

Check warning

Code scanning / clippy

use of deprecated field libp2p::libp2p_swarm::DialError::ConnectionLimit::0: Use libp2p::connection_limits instead and handle {Dial,Listen}Error::Denied::cause. Warning

use of deprecated field libp2p::libp2p\_swarm::DialError::ConnectionLimit::0: Use libp2p::connection\_limits instead and handle {Dial,Listen}Error::Denied::cause.
@ackintosh ackintosh merged commit f699b2a into main Aug 2, 2023
5 checks passed
@ackintosh ackintosh deleted the libp2p-0510 branch August 2, 2023 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant