Skip to content

Latest commit

 

History

History
28 lines (28 loc) · 2.16 KB

todo.org

File metadata and controls

28 lines (28 loc) · 2.16 KB

AcidExperiment

Development

Need to resave test data in AcidTest to reflect change in column names.

Need to address export conflict with BiocIO.

Warning: multiple methods tables found for ‘export’

selectSamples improvement ideas.

  • Rework using `colData` instead of `sampleData` internally? Can just match on factor columns, which likely is simpler and faster.
  • Consider hardening for scalars instead of just atomic values.
  • Unit test input of multiple values.
  • Error if user passes in a value that’s not defined.
  • Need to tighten our assert check about acceptable input.
  • Also need to harden to not let the user select based on sampleName or interestingGroups…these are dynamic. Alternatively, just extract colData and pick the factor columns. We can generalize this to selectColData instead, which is a bit simpler.
  • For sample identifier matching, can improve the logic here a bit.
    • Work on improving the variable names here, a bit confusing.
    • Need to handle case where input doesn’t match anything.
    • What about if user passes in 2 values…both MUST match!

MultiAssayExperiment export method improvements.

For use with cBioPortalAnalysis package.

  • Consider slotting the colData in per nested SE, to make the flat file exports easier to parse programatically.
  • If rowData contains “Hugo_Symbol”,”Entrez_Gene_Id”, consider assigning rownames from the `Entrez_GeneId`, but only if there are no duplicates.
  • Consider exporting with rowData bound to assay automatically.

sampleData assignment needs to factorize automatically.

Consider removing `estimateSizeFactors` code defined here in favor of simpler `normalize()` approach defined in AcidSingleCell.

`convertGenesToSymbols`: Need to add coverage for object containing NA values in gene symbols.

`makeSummarizedExperiment: Error if metadata input contains values we automatically assign (e.g. date, wd, etc).

sampleData assignment method needs to check for camelCase names.

All SummarizedExperiment S4 methods need to support `assay` argument when applicable.