Corrected the non working (wrong uploaded) Platforms18.xml on my previous PR #421 #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Now tested and verified working on my Lenovo B570e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My apologize @vandroiy2013 , somehow idk how i uploaded the wrong platforms18.xml which after i tested on my Lenovo B570e, after building from source, i noticed it wasn't working.
It was my fault of not testing it directly on my Lenovo B570e after building and before sending the PR.
Now i replaced with correct Platforms18.xml file, rebuild the kext, installed on my Lenovo B570e.
Now i can confirm 100% that it works correctly with this new Platforms18.xml as i just tested everything (all inputs and outputs), even after wake from sleep.
Again, sorry for taking your precious time & Thanks a lot !
With respect,
Sniki