Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[i18n] Wrap easy strings in gettext function #9398

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[i18n] Wrap easy strings in gettext function #9398

wants to merge 1 commit into from

Commits on Oct 9, 2024

  1. [i18n] Wrap easy strings in gettext function 

    This wraps the long hanging fruit of user-facing strings on the PHP
side of LORIS in the gettext function (using the _ alias). It does
not comprehensively do every string, because:
1. Some strings have variables embedded. A lookup into the gettext
   would not translate these
2. modules/*/ajax/* scripts are ignored, because they bypass the
   index.php/router/etc where the the domain is likely to be set
   by LORIS. The work of fixing them is assumed to be less than the
   work of updating them to proper endpoints.
3. Strings that weren't obvious if they would break anything are ignored
   (ie. keys in an array)
4. Probably some other that I'm forgetting

Nonetheless, it's a first pass at marking up our code with translatable
strings.
    Dave MacFarlane committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    6e4d453 View commit details
    Browse the repository at this point in the history