Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize integration Docker image #1195

Merged

Conversation

maximemulder
Copy link
Contributor

@maximemulder maximemulder commented Oct 3, 2024

Merge some easily mergeable steps and remove some unused dependencies in the dockerfile to reduce the number of Docker layers, which should free some space in our GitHub actions cache.

The "variables should be present before their use" warning was already present before. We'll look into removing it once we have actual integration tests running (still waiting on the S3 bucket for that).

@maximemulder maximemulder force-pushed the 2024-10-03_optimize-integration-image branch from aebb378 to a9a95fc Compare October 3, 2024 17:31
@maximemulder maximemulder marked this pull request as ready for review October 3, 2024 18:07
@cmadjar cmadjar added the A-CI Area: CI. Issues and pull requests related to CI, including automated tests and static checks label Oct 4, 2024
@cmadjar cmadjar added this to the 27.0 milestone Oct 4, 2024
@maximemulder maximemulder added the S-Small Size: Small. Simple pull requests that contain little code and should be easy to review label Oct 4, 2024
Copy link
Contributor

@kongtiaowang kongtiaowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cmadjar cmadjar merged commit 603b6d3 into aces:main Oct 4, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CI Area: CI. Issues and pull requests related to CI, including automated tests and static checks S-Small Size: Small. Simple pull requests that contain little code and should be easy to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants