Clean-up database scan type #1139
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximemulder
force-pushed
the
improve-database-scan-type
branch
from
2f91dd1
to
3379885
Compare
|
I am having some troubles testing this PR because my dev database config got changed recently, but this should work. According to the files changed, only the DICOM to MINC ingestion pipeline needs to be tested. |
|
@maximemulder there is a conflict in this PR. Could you rebase and let @nicolasbrossard and I when it is ready to test/review? Thank you :) |
maximemulder
force-pushed
the
improve-database-scan-type
branch
3 times, most recently
from
22a00c3
to
5e8b460
Compare
maximemulder
force-pushed
the
improve-database-scan-type
branch
from
5e8b460
to
0cf332b
Compare
maximemulder
added
the
S-Large
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complementary PR of LORIS #9304