Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Medical Treatment - Extract stitching & trauma code #10543

Merged
merged 13 commits into from
Jan 13, 2025
Merged

Medical Treatment - Extract stitching & trauma code #10543

merged 13 commits into from
Jan 13, 2025

Conversation

LinkIsGrim
Copy link
Contributor

@LinkIsGrim LinkIsGrim commented Dec 14, 2024 •
edited
Loading

When merged this pull request will:

  • Title.
  • Fix bandage reopening not adding trauma back.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@LinkIsGrim LinkIsGrim added the kind/cleanup Release Notes: **CHANGED:** label Dec 14, 2024
@LinkIsGrim LinkIsGrim changed the title Medical Treatment - Extract stitching code Medical Treatment - Extract stitching & trauma code Dec 14, 2024
@LinkIsGrim @PabstMirror
fix undefined vars
a9fd59a 
Co-authored-by: PabstMirror <[email protected]>
johnb432
johnb432 approved these changes Jan 5, 2025
View reviewed changes
Copy link
Contributor

@johnb432 johnb432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as is. Bandage reopening readding trauma has been tested and appears to be working.

@LinkIsGrim LinkIsGrim modified the milestones: 3.18.3, 3.18.2 Jan 13, 2025
@LinkIsGrim LinkIsGrim merged commit 77248d7 into master Jan 13, 2025
3 checks passed
@LinkIsGrim LinkIsGrim deleted the surgicalKit-separate-stitching branch January 13, 2025 19:37
@LinkIsGrim LinkIsGrim added kind/enhancement Release Notes: **IMPROVED:** and removed kind/cleanup Release Notes: **CHANGED:** labels Jan 13, 2025
PlayerBotPro pushed a commit to PlayerBotPro/ACE3 that referenced this pull request Jan 14, 2025
@LinkIsGrim @PabstMirror
@johnb432 @PlayerBotPro
Medical Treatment - Extract stitching & trauma code (acemod#10543)
6817a50 
Co-authored-by: PabstMirror <[email protected]>
Co-authored-by: johnb432 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PabstMirror PabstMirror PabstMirror left review comments

@DartRuffian DartRuffian DartRuffian left review comments

@johnb432 johnb432 johnb432 approved these changes

Assignees
No one assigned
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Milestone
3.19.0
Development

Successfully merging this pull request may close these issues.
4 participants
@LinkIsGrim @PabstMirror @johnb432 @DartRuffian