Medical - Add framework for pain dynamics || Improve code readability and error handling #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veteran29
requested changes
Aug 24, 2024
| //------------------------------------------------------------------------------------------------ | ||
| //! Initialize member variables | ||
| //! Initialize member variables. |
There was a problem hiding this comment.
None of the other doc blocks end with a punctuation, keep consistent
Suggested change
| //! Initialize member variables. | |
| //! Initialize member variables |
|
|
||
| //------------------------------------------------------------------------------------------------ | ||
| //! Handle logic when character is revived (ALIVE state) | ||
| void HandleAliveState() |
There was a problem hiding this comment.
this is not a public API
Suggested change
| void HandleAliveState() | |
| protected void HandleAliveState() |
|
|
||
| //------------------------------------------------------------------------------------------------ | ||
| //! Handle logic when character is incapacitated (INCAPACITATED state) | ||
| void HandleIncapacitatedState() |
There was a problem hiding this comment.
Suggested change
| void HandleIncapacitatedState() | |
| protected void HandleIncapacitatedState() |
|
|
||
| //------------------------------------------------------------------------------------------------ | ||
| //! Handle logic when character is dead (DEAD state) | ||
| void HandleDeadState() |
There was a problem hiding this comment.
Suggested change
| void HandleDeadState() | |
| protected void HandleDeadState() |
Comment on lines
-18
to
-20
| // We only notify the replication system about changes of these members on initialization | ||
| // After init, each proxy is itself responsible for updating these members | ||
| // Having them as RplProp also ensures that JIPs receive the current state from the server |
There was a problem hiding this comment.
I don't see the point of removing a useful comment.
| m_bACE_Medical_Initialized = true; | ||
| Replication.BumpMe(); | ||
|
|
||
| // Log successful initialization | ||
| Print("ACE Medical: Initialized with second chance enabled.", LogLevel.INFO); |
There was a problem hiding this comment.
Could you add info about m_bSecondChanceOnHeadEnabled, m_fSecondChanceRegenScale values here?
I don't see any of this in the PR, and in general it would make sense to keep them separate from the minor refactor so it's easier to review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will: