Skip to content

Commit

Permalink
test: mark model sanity tests xfail
Browse files Browse the repository at this point in the history
Some model sanity checking was implemented in the old
ModelBindingsMapper, all checking should be done in a dedicated model
sanity checking pipeline, see issue #108.

So these tests - for now - are xfails.
  • Loading branch information
lu-pl committed Jan 20, 2025
1 parent 11e5624 commit 827c6ad
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion tests/tests_mapper/test_sad_path_mapper_grouped_models.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
from pydantic import BaseModel
import pytest

from pydantic import BaseModel
from rdfproxy import ConfigDict, ModelBindingsMapper
from rdfproxy.utils._exceptions import (
InvalidGroupingKeyException,
Expand All @@ -17,11 +18,13 @@ class ModelMissingGroupByValue(BaseModel):
x: list[int]


@pytest.mark.xfail(reason="Not yet implemented, checks will run in model checkers.")
def test_sad_path_adapter_missing_grouping_config():
with pytest.raises(MissingModelConfigException):
ModelBindingsMapper(ModelMissingGroupByConfig, {"x": 1}).get_models()


@pytest.mark.xfail(reason="Not yet implemented, checks will run in model checkers.")
def test_sad_path_adapter_missing_grouping_value():
with pytest.raises(InvalidGroupingKeyException):
ModelBindingsMapper(ModelMissingGroupByValue, {"x": 1}).get_models()

0 comments on commit 827c6ad

Please sign in to comment.