Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export feature for list views #1559

Merged
merged 2 commits into from
Jan 29, 2025
Merged

export feature for list views #1559

merged 2 commits into from
Jan 29, 2025

Conversation

gythaogg
Copy link
Contributor

This pull request includes changes to the apis_core/generic/views.py file and updates to the pyproject.toml file to add export functionality and a new dependency. The most important changes are summarized below:

Export Functionality:

  • Added ExportMixin to the imports and to the List class in apis_core/generic/views.py to enable export functionality. [1] [2]
  • Implemented the get_export_filename method to generate filenames for exported tables based on the current date and time.

Dependency Update:

  • Added tablib version 3.8.0 to the dependencies in pyproject.toml to support data export features.

@gythaogg gythaogg requested a review from b1rger January 28, 2025 10:15
@gythaogg gythaogg marked this pull request as draft January 28, 2025 10:15
@gythaogg gythaogg force-pushed the gythaogg/export-listviews branch from 0840c5e to 949c14d Compare January 28, 2025 10:17
@gythaogg gythaogg marked this pull request as ready for review January 28, 2025 10:22
@gythaogg gythaogg force-pushed the gythaogg/export-listviews branch from 949c14d to b332c1d Compare January 28, 2025 10:27
apis_core/generic/views.py Show resolved Hide resolved
@gythaogg gythaogg force-pushed the gythaogg/export-listviews branch 2 times, most recently from 6a43353 to 9fee49a Compare January 28, 2025 10:55
@gythaogg gythaogg marked this pull request as draft January 28, 2025 10:56
@gythaogg gythaogg force-pushed the gythaogg/export-listviews branch from 9fee49a to 511bbc0 Compare January 28, 2025 11:01
@gythaogg gythaogg marked this pull request as ready for review January 28, 2025 11:01
@gythaogg gythaogg requested a review from b1rger January 28, 2025 11:03
@gythaogg gythaogg force-pushed the gythaogg/export-listviews branch 3 times, most recently from 8ed1d50 to 3d11f98 Compare January 28, 2025 13:02
apis_core/generic/views.py Outdated Show resolved Hide resolved
@gythaogg gythaogg force-pushed the gythaogg/export-listviews branch from 3d11f98 to 6f1a8c3 Compare January 29, 2025 08:18
@gythaogg gythaogg requested a review from b1rger January 29, 2025 08:19
@b1rger b1rger force-pushed the gythaogg/export-listviews branch from 6f1a8c3 to ed40cf7 Compare January 29, 2025 08:25
@b1rger
Copy link
Contributor

b1rger commented Jan 29, 2025

(I took the liberty of rebasing)

@gythaogg gythaogg merged commit c8c7670 into main Jan 29, 2025
14 checks passed
@gythaogg gythaogg deleted the gythaogg/export-listviews branch January 29, 2025 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants