feat: add new form to referenceonlist #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b1rger
force-pushed
the
birger/form-to-referenceonlist
branch
3 times, most recently
from
03b4ba8
to
d070618
Compare
sennierer
reviewed
Jun 27, 2023
There was a problem hiding this comment.
works on my setup apart from a CSS issue.
when selecting an item the text in the box is not wrapped. According to a colleague more capable of CSS than I am thats because the text is meant to be truncated but thats not working when the parent modal is set to relativ width (100%) and that is not correctly handed through the whole structure.
Deselecting the select2-selection--single class fixes the problem. It introduces the nowrap
If this is difficult to fix, I think we can all live with that, just wanted to mention it.
This commit introduces a `ReferenceNewForm`, which is a basic form for References. This form is added to the ReferenceOnListView. The form is also included in the ReferenceOnListView template. It uses htmx, so the page does not have to reload if a new entry is added. To make this work, there is a `reinit_select2.html` partial which works around bugs with the dal/select2 implementation in and htmx. Another fix is in the `fix_select2_bootstrap_focus.html` partial: if we want to load a view with a select2 form via a modal, we have to override a function to prevent the bootstrap modal from stealing the focus.
This commit adds a small javascript snipplet to the `reference_list.html` template which autofills the bibsonomy forms `bibs_url` field with the data from the last added bibsonomy.
This commit introduces a `link_to_reference_on` reference tag, which can be used to include link to the referenceonview from other modules. The tag expects a model instance as argument. It then creates a link to the reference on view. If the `modal` argument is passed to the templatetag, the created link uses htmx to fill a modal with the id #modal-here
b1rger
force-pushed
the
birger/form-to-referenceonlist
branch
from
d070618
to
72a3bce
Compare
ah, thanks! I fixed the problem by adding another partial containing the styledefinition: <style>
.select2-selection__rendered{
word-wrap: break-word !important;
text-overflow: inherit !important;
white-space: normal !important;
}
</style> |
sennierer
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a form to the
referenceonlistview that allows to add new references.