Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live tunneler #66

Merged
merged 15 commits into from
Dec 9, 2019
Merged

Live tunneler #66

merged 15 commits into from
Dec 9, 2019

Conversation

lucamattiazzi
Copy link
Contributor

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Refactoring / Code style update (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other (please describe):

Added possibility to expose the local dev server to outside networks.

Does this introduce a breaking change?

  • Yes
  • No

Copy link
Contributor

@marcofugaro marcofugaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Some comment to make the code more maintainable

  • Please write some tests, at least to test that it creates the exposed link correctly, no need to make requests in the test
    image
    (error replicable with yarn create-test-app && cd test-app/ && yarn start --exposed)

  • Any idea why is this popping up?
    image

@marcofugaro
Copy link
Contributor

@YeasterEgg what about requiring ssh-tuna as a dependency and importing the functions from there?

@lucamattiazzi
Copy link
Contributor Author

@marcofugaro yep that's what I'm doing now, no need to rewrite stuff

@marcofugaro
Copy link
Contributor

@YeasterEgg quella cosa dello stdio, credo si faccia così

image

Attento comunque a non ritornare la stringa sbagliata dalla funzione

@lucamattiazzi
Copy link
Contributor Author

@marcofugaro in realtà se faccio come dici tu non ritorno nulla, l'array si riferisce rispettivamente a STDIN, STDOUT e STDERR, e se metto pipe, pipe e ignore posso ricevere il risultato corretto ignorando del tutto gli errori

Copy link
Contributor

@marcofugaro marcofugaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still errors in the tests, run

yarn create-test-app
cd test-app/ && yarn start --exposed

image

@lucamattiazzi
Copy link
Contributor Author

lucamattiazzi commented Dec 9, 2019

@marcofugaro I've updated ssh-tuna to handle errors

Copy link
Contributor

@marcofugaro marcofugaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcofugaro marcofugaro merged commit e12ea26 into master Dec 9, 2019
@marcofugaro marcofugaro deleted the live-tunneler branch December 9, 2019 17:45
marcofugaro added a commit that referenced this pull request Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants