Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Readme FAQ on how to set up SEO using react-snap and react-helmet #44

Closed

Conversation

ruggerocastagnola
Copy link
Contributor

No description provided.

@marcofugaro marcofugaro self-requested a review December 6, 2018 13:37
Copy link
Contributor

@marcofugaro marcofugaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Purtroppo prettier mi sputtana gli esempi di codice e li rende meno leggibili 😞

Sono pro all'utilizzo di prettier, ma non nel readme, riusciresti a mettere REAMDE.md nel file .prettierignore e a rifare le modifiche? Grazie.

PS ti ho invitato nel team accurat, strano che tu non fossi dentro, la prossima volta fai le pr direttamente da branch di questa repo, così posso contribuirci anch'io 🙂

return (
<Helmet>
<title>Home title</title>
<meta name="robots" content="index,follow" />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you want SEO, why do you prohibit indexing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi stereobooster, thank you for taking the time to make comments on this pr, very appreciated, and thanks for the amazing work with react-snap. I agree this is redundant and will be removed.

or the following meta to be added to the `<Helmet>` component:

```
<meta name="prerender-status-code" content="404" />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not implemented

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I'll reference #91 instead

@ruggerocastagnola
Copy link
Contributor Author

Closing in favor of #45

@ruggerocastagnola ruggerocastagnola deleted the seo-config-readme branch December 15, 2018 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants