-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Readme FAQ on how to set up SEO using react-snap and react-helmet #44
Added Readme FAQ on how to set up SEO using react-snap and react-helmet #44
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Purtroppo prettier mi sputtana gli esempi di codice e li rende meno leggibili 😞
Sono pro all'utilizzo di prettier, ma non nel readme, riusciresti a mettere REAMDE.md
nel file .prettierignore
e a rifare le modifiche? Grazie.
PS ti ho invitato nel team accurat, strano che tu non fossi dentro, la prossima volta fai le pr direttamente da branch di questa repo, così posso contribuirci anch'io 🙂
return ( | ||
<Helmet> | ||
<title>Home title</title> | ||
<meta name="robots" content="index,follow" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you want SEO, why do you prohibit indexing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi stereobooster, thank you for taking the time to make comments on this pr, very appreciated, and thanks for the amazing work with react-snap. I agree this is redundant and will be removed.
or the following meta to be added to the `<Helmet>` component: | ||
|
||
``` | ||
<meta name="prerender-status-code" content="404" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not implemented
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, I'll reference #91 instead
Closing in favor of #45 |
No description provided.