Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Clean build folder and use build path from webpack.config.js #28

Merged
merged 1 commit into from
Aug 1, 2017

Conversation

markov00
Copy link
Contributor

This fix will clean the build folder before compilation and allows to change the build path on your local webpack.config.js file

…webpack config

This fix will clean the build folder before compilation and allows to change the build path on your local webpack.config.js file
@markov00 markov00 requested a review from caesarsol July 27, 2017 17:21
@caesarsol caesarsol merged commit 397477b into accurat:master Aug 1, 2017
@caesarsol
Copy link
Contributor

👍 !

@marcofugaro
Copy link
Contributor

👮 Ehi ehi @markov00 I am seeing some compiled files in the repo, what is the folder test_build/ for?

Did you know about the yarn create-test-app script?

@markov00
Copy link
Contributor Author

markov00 commented Aug 8, 2017

Sorry for that @marcofugaro, strange that I also commited these files.
I knows about create-test-app but from @caesarsol not from the repo itself. Maybe adding this to the README.md file can help in a better contribution

@marcofugaro
Copy link
Contributor

👌 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants