Skip to content

Commit

Permalink
Merge pull request #40 from accurat/big-updates
Browse files Browse the repository at this point in the history
Big various updates
  • Loading branch information
marcofugaro authored Aug 31, 2018
2 parents aee8593 + bf6a963 commit ba1268a
Show file tree
Hide file tree
Showing 42 changed files with 5,889 additions and 3,083 deletions.
2 changes: 1 addition & 1 deletion .gitignore
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
node_modules/
.DS_Store
*.log
test-app/*
test-app/
39 changes: 0 additions & 39 deletions LICENSE
Original file line number Diff line number Diff line change
@@ -1,42 +1,3 @@
Since this code was forked from create-react-app, some
lines of code fall under React's original BSD license.
New code is licensed under MIT.

---

BSD License

For create-react-app software

Copyright (c) 2016-present, Facebook, Inc. All rights reserved.

Redistribution and use in source and binary forms, with or without modification,
are permitted provided that the following conditions are met:

* Redistributions of source code must retain the above copyright notice, this
list of conditions and the following disclaimer.

* Redistributions in binary form must reproduce the above copyright notice,
this list of conditions and the following disclaimer in the documentation
and/or other materials provided with the distribution.

* Neither the name Facebook nor the names of its contributors may be used to
endorse or promote products derived from this software without specific
prior written permission.

THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND
ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR
ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
(INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

---

The MIT License (MIT)

Copyright (c) 2017-present Accurat Srl
Expand Down
50 changes: 50 additions & 0 deletions MIGRATION-GUIDE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
# Migrating to AccurApp v4.x

This is the migration guide for upgrading from AccurApp v3.x to v4.x. It is a major update with a couple of breaking changes.

- The `webpack-preset-accurapp` changed its default export, this is the new basic `webpack.config.js`:
```js
const { buildWebpackConfig } = require('webpack-preset-accurapp')

module.exports = buildWebpackConfig()
```

- You will need to explicitly set the browserslist in your `package.json`, this will affect Babel and Autoprefixer, this is the suggested config for example:
```json
"browserslist": {
"production": [
">0.25%",
"not ie 11",
"not op_mini all"
],
"development": [
"last 1 Chrome version"
]
}
```

- You can now configure Babel, make a new `.babelrc` in the project root with these contents
```json
{
"presets": ["accurapp"]
}
```
and run `yarn add --dev babel-preset-accurapp`

- setting the `NODE_ENV` from the outside is being deprecated, it is preferred to use different Env variables or some argv arguments.
So the previous CI script for staging
```yml
script:
- NODE_ENV=staging yarn build
```
now becomes
```yml
script:
- GENERATE_SOURCEMAP=true yarn build
```
This is more explicit.
- add the lint script to scripts section in the package.json:
```json
"lint": "accurapp-scripts lint",
```
Loading

0 comments on commit ba1268a

Please sign in to comment.