Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kubearmor relay connection logic #766

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Fix kubearmor relay connection logic #766

merged 1 commit into from
Jul 5, 2023

Conversation

seswarrajan
Copy link
Contributor

Purpose of PR?:
Fix Kubearmor relay connection logic
Problem statement : DE tries to reconnect even when the connection to relay is successful.

Fixes #

Does this PR introduce a breaking change?
No

If the changes in this PR are manually verified, list down the scenarios covered::
Relay connection and failure cases

Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

  • Bug fix. Fixes #
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Commit has unit tests
  • Commit has integration tests

Signed-off-by: Eswar Rajan Subramanian <[email protected]>
Copy link
Contributor

@Ankurk99 Ankurk99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@achrefbensaad achrefbensaad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@stefin9898 stefin9898 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seswarrajan seswarrajan merged commit 77d8467 into accuknox:dev Jul 5, 2023
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants