Update CMake Python dependency for NumPy #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the NumPy component to find_package for async_suspend and
add ${Python3_NumPy_INCLUDE_DIRS} to the target_include_directories
list.
Signed-off-by: Brandon Parsons <[email protected]>
|
Seems reasonable - THANKS |
markfoodyburton
approved these changes
Sep 24, 2024
maehne
approved these changes
Sep 24, 2024
lmailletcontoz
merged commit fcb75f4
into
accellera-official:main
37 of 71 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the NumPy component to Python3 find_package for async_suspend and add ${Python3_NumPy_INCLUDE_DIRS} to the target_include_directories list.
Without it, builds that set ASYNC_SUSPEND_MATPLOT may fail to find
numpy/arrayobject.h