Various IPVS updates for adding/removing real/sorry servers and changing inhibit #2380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…data Signed-off-by: Quentin Armitage <[email protected]>
Commit 13c1d5c - "ipvs: Add/remove sorry server of group server when reload" didn't handle inhibited sorry servers correctly. We don't want to check for alive, but rather set. Signed-off-by: Quentin Armitage <[email protected]>
When there is no sorry server, the quorum is not used, and real servers are only removed if a checker fails. On the other hand if there is a sorry server, if the number of alive real servers falls below the quorum, all non-failed real servers are removed when the sorry server is added. If the sorry server is remomed from the configuration, non-failed real servers need to be reinstated. Signed-off-by: Quentin Armitage <[email protected]>
If there is a configuration change that adds inhibit_in_failure to the sorry server but the sorry server is alive, the code was disabling the sorry server. This commit corrects that. Signed-off-by: Quentin Armitage <[email protected]>
If inhibit for a failed real server is changed on a reload, the real server will need to be added (if inhibit is now set) or removed if inhibit is cleared. Signed-off-by: Quentin Armitage <[email protected]>
If a reload sets a sorry server to inhibited and the sorry server is not active, then it needs to be added to the running configuration with wieght 0 rather than weight 1. Signed-off-by: Quentin Armitage <[email protected]>
If a reload clears inhibit for an inactive sorry server, the sorry server is removed from the live ipvs configuration. Internally the set flag needs to be cleared. Signed-off-by: Quentin Armitage <[email protected]>
Signed-off-by: Quentin Armitage <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.