Add support for reproducable builds, and other minor build system fixes #2376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Quentin Armitage <[email protected]>
…FILE
We need to check and remove a leading "NONE" from ${sysconfdir} when
using to generate the DEFAULT_CONFIG_FILE.
Signed-off-by: Quentin Armitage <[email protected]>
Commit 42a746c - "configure: ${prefix} defaults to NONE which messes up DEFAULT_CONFIG_FILE" had a script error, which is now fixed. Signed-off-by: Quentin Armitage <[email protected]>
There are users who want reproducable builds in the event that the paths to header files change between builds. Due to 'keepalived -v' outputting (build) configure options, if the location of the header files changed, then the keepalived binary would change. If keepalived is build with the --enable-reproducable-build option, then the configure options are written to keepalived/keepalived.config-opts in the build tree, which is then installed to $(DESTDIR)/etc/keepalived/keepalived.config-opts (or whereever the default config file is installed). keepalived reads this file for generating the 'keepalived -v' output (and also coredump log entries), and so this file must be installed correctly for keepalived to run. If --enable-reproducable-build is not specified to configure, then the behaviour of keepalived and the required installed files are not changed. Signed-off-by: Quentin Armitage <[email protected]>
Commit 30d2f7 - "build: Add configure option --enable-reproducable-build" misspelled reproducible. s/reproducable/reproducible/ A bit embarrassing really. :( Signed-off-by: Quentin Armitage <[email protected]>
Signed-off-by: Quentin Armitage <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.