Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc update and stop setting MAGIC_PRESERVE_ATIME #2335

Merged
merged 2 commits into from
Aug 23, 2023
Merged

doc update and stop setting MAGIC_PRESERVE_ATIME #2335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af61b26
doc: update description for v3_checksum_as_v2
pqarmitage Aug 19, 2023
b2b6539
lib: Stop setting MAGIC_PRESERVE_ATIME flag
pqarmitage Aug 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions doc/man/man5/keepalived.conf.5.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1794,11 +1794,13 @@ The syntax for vrrp_instance is :
# of `keepalived -v` for OLD_CHKSUM_COMPAT.]
\fBold_unicast_checksum \fR[never]

# Some manufacturers (e.g. Cisco) interpret RFC5798 5.2.8 as applying
# only to IPv6, since the pseudo-header in RFC2460 is specified only
# for IPv6. Keepalived by default uses a pseudo-header for VRRPv3 IPv4
# as well. Setting this option turns off including the pseudo-header
# in the checksum calculation for VRRPv3 IPv4.
# Some manufacturers (e.g. Cisco and Juniper) interpret RFC5798 5.2.8
# as applying only to IPv6, since the pseudo-header in RFC2460 is
# specified only for IPv6, although most open source implementations,
# including tcpdump/wireshark, include the pseudo-header for IPv4.
# Keepalived by default uses a pseudo-header for VRRPv3 IPv4 as well.
# Setting this option turns off including the pseudo-header in the
# checksum calculation for VRRPv3 IPv4.
\fBv3_checksum_as_v2\fR [<BOOL>]

# interface specific settings, same as global parameters.
Expand Down
2 changes: 1 addition & 1 deletion lib/keepalived_magic.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
static inline magic_t
ka_magic_open(void)
{
magic_t magic = magic_open(MAGIC_PRESERVE_ATIME | MAGIC_ERROR | MAGIC_NO_CHECK_CDF | MAGIC_NO_CHECK_COMPRESS);
magic_t magic = magic_open(MAGIC_ERROR | MAGIC_NO_CHECK_CDF | MAGIC_NO_CHECK_COMPRESS);
if (!magic)
log_message(LOG_INFO, "Unable to open magic");
else if (magic_load(magic, NULL)) {
Expand Down
Loading