IO: implement process wrapper for win32 #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is the convention for this project. Should've done it back when I was porting everything to CMake.
It's inconvenient to keep two separate libraries and somehow share helpers between them. It makes sense to have "process" in io, so I'm moving it there.
Provides additional information about the test. For now it's just the exe_dir to know where the test excutable is located (useful if tests rely on external data that's bundled with the tet executable)
Hedede
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
processintoioto reduce code duplication between io and platform. In the future, there's going to be IPC soiois a fitting place.processforwin32run()andwait(). For nowposixversion ofwait()doesn't have a timeout parameter