Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPX-24 - Add support for CoAP and DTLS #60

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

felixgateru
Copy link
Contributor

@felixgateru felixgateru commented Apr 12, 2024

What does this do?

This is a feature as it adds coap proxy support without DTLS as well as DTLS temination for CoAP messaging.

Which issue(s) does this PR fix/relate to?

Resolves #24
Related issue https://github.com/absmach/magistrala/issues/1963

List any changes that modify/break current functionality?

None.

Have you included tests for your changes?

No

Did you document any new/modified functionality?

Yes, in incode comments

Notes

N/A

@felixgateru felixgateru force-pushed the mpx_24-coap branch 4 times, most recently from ad62fd9 to e07a87a Compare April 19, 2024 07:29
@felixgateru felixgateru marked this pull request as ready for review April 19, 2024 07:48
pkg/coap/coap.go Outdated Show resolved Hide resolved
pkg/coap/coap.go Outdated Show resolved Hide resolved
pkg/tls/tls.go Outdated Show resolved Hide resolved
pkg/tls/tls.go Outdated Show resolved Hide resolved
pkg/coap/coap.go Outdated Show resolved Hide resolved
@felixgateru felixgateru force-pushed the mpx_24-coap branch 3 times, most recently from 6368bb4 to e2586a5 Compare April 25, 2024 15:15
config.go Show resolved Hide resolved
Copy link
Member

@rodneyosodo rodneyosodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, send a corresponding PR to masgistrala for coap to use mproxy

pkg/tls/tls.go Outdated Show resolved Hide resolved
pkg/tls/tls.go Outdated Show resolved Hide resolved
pkg/tls/tls.go Outdated Show resolved Hide resolved
pkg/coap/coap.go Outdated Show resolved Hide resolved
@arvindh123
Copy link
Contributor

@1998-felix
It will be great if we provide example scripts to test the coap server and client, like how we have for MQTT, WS, HTTP with documentation in readme.md.

config.go Show resolved Hide resolved
pkg/coap/coap.go Outdated Show resolved Hide resolved
examples/client/coap/with_dtls.sh Show resolved Hide resolved
README.md Show resolved Hide resolved
pkg/coap/coap.go Outdated Show resolved Hide resolved
pkg/coap/coap.go Outdated Show resolved Hide resolved
pkg/coap/coap.go Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@felixgateru felixgateru force-pushed the mpx_24-coap branch 3 times, most recently from 0089ebe to bf74bc3 Compare May 23, 2024 14:57
@nyagamunene
Copy link
Contributor

LGTM

nyagamunene
nyagamunene previously approved these changes May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🩺 Review and testing
Development

Successfully merging this pull request may close these issues.

Add support for CoAP and DTLS
6 participants