Adding Phoenix.Presence functionality #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First pass at adding Phoenix.Presence
This allows us to wait for our current handler to execute fully and the client to prepare itself before it receives any data
Add ready_for_data clause
| socket.assigns | ||
| |> Map.get(:absinthe, %{}) | ||
| |> Map.get(:opts, []) | ||
| |> Keyword.get(:context, %{handler: nil}) |
There was a problem hiding this comment.
why do we need %{handler: nil} here?
There was a problem hiding this comment.
Because you cannot do Map.get(nil, :handler) which will happen if the context is missing from opts
There was a problem hiding this comment.
This whole chain feels like it would be improved with use of Access since it is nil resilient:
socket.assigns[:absinthe][:opts][:context][:handler]
| @doc """ | ||
| Function to call the Phoenix.Presence.list/1 callback from the module that the user has configured in __absinthe_presence_config__. | ||
| """ | ||
| def list(socket = %{assigns: %{__absinthe_presence_config__: presence_config}}) |
There was a problem hiding this comment.
Elixir can pattern match at multiple levels
Suggested change
| def list(socket = %{assigns: %{__absinthe_presence_config__: presence_config}}) | |
| def list(socket = %{assigns: %{__absinthe_presence_config__: %{module: module}}}) when is_binary(module) do | |
| module.list(socket) | |
| end | |
There was a problem hiding this comment.
is_binary module is wrong through, would need to be is_atom.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should address #39