Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements, and plans for the future. #68

Open
myusko opened this issue Apr 14, 2021 · 15 comments
Open

Improvements, and plans for the future. #68

myusko opened this issue Apr 14, 2021 · 15 comments

Comments

@myusko
Copy link
Collaborator

myusko commented Apr 14, 2021

@michaelbukachi, we should collect all suggestions/thoughts from the community, on which things we should focus on in the future, which features we should implement, and what type of improvements the community would like to see sqlalchemy-mixins.

Any comments/suggestions from the community are welcomed!

@michaelbukachi
Copy link
Collaborator

At the moment, we are working on SQLAlchemy 1.4/2.0 support. There are a couple of PRs open but they haven't been thoroughly tested.

@myusko
Copy link
Collaborator Author

myusko commented Apr 14, 2021

At the moment, we are working on SQLAlchemy 1.4/2.0 support. There are a couple of PRs open but they haven't been thoroughly tested.

Awesome! I'll go through PR's tomorrow, and also plan to write my thoughts regarding improvements, etc.

@myusko
Copy link
Collaborator Author

myusko commented Apr 15, 2021

Ok, from my side I want to share the next things, to consider them as new features/improvements.

  • Add mkdocs support, it has a nice material UI and will allow us to have new stylish documentation.
  • Add type hinting(?)
  • Clean up the repository(probably some refactoring), and all docstrings should be updated/added(?)
  • Decide which Python version we won't support(?)

Also, this list will be updated, once new ideas will arrive.

cc @michaelbukachi

@michaelbukachi
Copy link
Collaborator

Thanks @myusko. I'll add to the list as soon as I'm home.

@michaelbukachi
Copy link
Collaborator

michaelbukachi commented Apr 16, 2021

To continue where @myusko left off,

  • For the python versions, the current minimum is 3.5. Apparently, that's the minimum support version on actions. See this failed action. So currently, the minimum version is 3.5
  • We should definitely prioritize type hinting and add mypy checks to the actions as well. This will improve readability and code navigation.
  • Come up with a better syntax for conjunction operators (AND, OR). There's a PR open but I feel that it can be improved. We should strive for the simplicity the creator of the library envisioned.

@myusko
Copy link
Collaborator Author

myusko commented Apr 19, 2021

@michaelbukachi I totally agree that mypy should be added, let's create an issue for it, also in the documentation, we also should mention that the minimum Python version is 3.5.

Regarding, the conjunction operators, I also agree, and definitely, we should strive for simplicity, as you mentioned.

@michaelbukachi
Copy link
Collaborator

@myusko I've updated the readme.
If I get time during the day, I'll create the ticket and the details of what needs to be done for mypy ticket.

@SK-FComputer
Copy link

@michaelbukachi you should specify that version needs to be 3.5 and above
Current docs reads like it is only 3.5

@myusko
Copy link
Collaborator Author

myusko commented Apr 21, 2021

@SK-FComputer I'll update this, thank you!

@aurthurm
Copy link
Contributor

Are there plns to support async sqlalchemy i future?

@ZhymabekRoman
Copy link

Are there plns to support async sqlalchemy i future?

Yeah, same question

@michaelbukachi
Copy link
Collaborator

@aurthurm @ZhymabekRoman async is quite stable on SQAlchemy and is still heavily under development. We'd rather wait till it's completely stable rather than do a lot of fire fighting with each SQLAlchemy release.

@aurthurm
Copy link
Contributor

aurthurm commented Mar 29, 2022

@aurthurm @ZhymabekRoman async is quite stable on SQAlchemy and is still heavily under development. We'd rather wait till it's completely stable rather than do a lot of fire fighting with each SQLAlchemy release.

@michaelbukachi we can have an async branch for async functionality and not use master branch so that we can start brainstorming the async functionality. Those interested in using the features can use as we wait for the stable version.

WIll be happy to share how i refactored the mixins to suport async functinality. My approach might not have been the best but am willing to put it on the table and open for suggestions.

@michaelbukachi
Copy link
Collaborator

Hey, @aurthurm sure thing. Looking forward to your PR!

@aurthurm
Copy link
Contributor

Hey, @aurthurm sure thing. Looking forward to your PR!

Hie @michaelbukachi, I have added an issue and a pull request to this.

Awaiting your insights

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants