Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add synonyms to the list of "settable_attributes" #57

Open
sarapple opened this issue Mar 4, 2021 · 1 comment
Open

Please add synonyms to the list of "settable_attributes" #57

sarapple opened this issue Mar 4, 2021 · 1 comment

Comments

@sarapple
Copy link

sarapple commented Mar 4, 2021

Hi there- not sure if this project is still active,

The sqlalchemy Synonym column names are not contained in the list of settable_attributes.

https://docs.sqlalchemy.org/en/14/orm/mapped_attributes.html#synonyms

There is a check here for determining if the updated field is in the list of settable_attributes, and synonyms should be a settable field, per documentation on sqlalchemy.

def fill(self, **kwargs):

I unfortunately was not able to find where this field is set on the sqlalchemy orm side. If someone can point me to where it is, I would be happy to open a PR.

Thanks!
Sara

@myusko
Copy link
Collaborator

myusko commented Apr 15, 2021

@sarapple Hey there, thanks for the reporting.

First of all, the project is active and will be supported, I've created an issue, where we collect all future requests from the community, please see #68

Regarding your suggestion, we will review it, and if it makes sense, we definitely will fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants