Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker-compose.yaml #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zotochev
Copy link

You have conflicting lines in order_service/Dockerfile and docker-compose.yaml

order_service/Dockerfile

COPY ./app_common order_service/app_common

./docker-compose.yaml

volumes:
  - ./order_service/order_service:/code/order_service

This lines meant to do the same thing copy service source code to the container but volumes statement does not copy app_common/* code and because of it I could not start this demo for some time. It appeared that there was not app_common directory in order_service and order_service_worker containers

You have conflicting lines in `order_service/Dockerfile` and `docker-compose.yaml`

order_service/Dockerfile
```
COPY ./app_common order_service/app_common
```
./docker-compose.yaml
```
volumes:
  - ./order_service/order_service:/code/order_service
```
This lines meant to do the same thing copy service source code to the container but `volumes` statement does not copy `app_common/*` code and because of it I could not start this demo for some time. It appeared that there was not `app_common` directory in `order_service` and `order_service_worker` containers
@zotochev
Copy link
Author

Or maybe it is better to update docker-compose.yaml

volumes:
  - ./order_service/order_service:/code/order_service
  - ./app_common:/code/order_service/app_common 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant