Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trim whitespace from username and password during sign-in #22010

Closed
wants to merge 3 commits into from
Closed

Trim whitespace from username and password during sign-in #22010

wants to merge 3 commits into from

Conversation

realLiangshiwei
Copy link
Member

Description

Resolves #21915

Checklist

  • I fully tested it as developer / designer and created unit / integration tests
  • I documented it (or no need to document or I will create a separate documentation issue)

How to test it?

Add space to password when login

@realLiangshiwei realLiangshiwei added this to the 9.2-preview milestone Jan 27, 2025
oykuermann
oykuermann requested changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@oykuermann oykuermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • If we should ignore spaces at the beginning and end of password when logging in, then we should do the same rules on Register, Password change, Account personal info settings, and every place we can change/enter password and username. If a user has spaces at the beginning and end of password or username, he/she cannot log in to the system. Please apply this to all the UIs.

  • If we have space before username on login screen we cannot log in:

screen-capture.6.webm

@realLiangshiwei
Copy link
Member Author

After checking, ABP allows spaces to be used as part of a password, and this change may cause issues. closed

@realLiangshiwei realLiangshiwei removed this from the 9.2-preview milestone Feb 3, 2025
@realLiangshiwei realLiangshiwei deleted the liangshiwei/signinmanager branch February 3, 2025 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oykuermann oykuermann oykuermann requested changes

@maliming maliming maliming approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should ignore spaces at the beginning and end of password when logging in
3 participants
@realLiangshiwei @maliming @oykuermann