-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rust binary support #1435 #1488
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add support to get packages from rust binaries * Add support for rust source to binary mapping using symbols Reference: #1435 Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
We were failing on the d2d pipelines if we uploaded a single binary on the to side, as the d2d pipeline requires uploading an archive only. Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
We were having a lot of extra logger lines in certain cases previously on selecting wrong options, as the traceback was being shown in the log too. So this creates a warning instead of a log entry. Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
6 tasks
AyanSinhaMahapatra
force-pushed
the
add-rust-binary-support
branch
from
December 30, 2024 09:09
11a1a42
to
c156b08
Compare
tdruez
approved these changes
Dec 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The good looks good, I've added a few suggestions.
Also, make sure to always include new pipe and pipeline modules in the documentation.
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
AyanSinhaMahapatra
force-pushed
the
add-rust-binary-support
branch
from
December 30, 2024 13:15
3fe3bf1
to
4784304
Compare
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
All green, thanks for the reviews @tdruez 😄 Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for parsing rust binaries (#1435):
Rust
) in thedeploy_to_develop
pipeline to map rust binaries to rust source filesrust-inspector
at https://pypi.org/project/rust-inspector/0.1.0/cargo-auditable
)