Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support rust binary parsing #1

Merged
merged 5 commits into from
Dec 30, 2024
Merged

Conversation

AyanSinhaMahapatra
Copy link
Member

Reference: aboutcode-org/scancode.io#1435

Support parsing rust binaries and getting:

  1. Symbols
  2. Packages and Dependencies

Support parsing rust binaries and getting:

1. Symbols
2. Packages and Dependencies

Reference: aboutcode-org/scancode.io#1435
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking fine overall, see some minor nits inline for your review.
Please merge as you like.

src/rust_inspector/binary.py Show resolved Hide resolved
src/rust_inspector/binary.py Show resolved Hide resolved
src/rust_inspector/binary.py Outdated Show resolved Hide resolved
src/rust_inspector/binary.py Outdated Show resolved Hide resolved
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
@AyanSinhaMahapatra
Copy link
Member Author

All green, thanks @pombredanne for the review! Merging!

@AyanSinhaMahapatra AyanSinhaMahapatra merged commit 9c92c8a into main Dec 30, 2024
7 checks passed
@AyanSinhaMahapatra AyanSinhaMahapatra deleted the support-rust-binary branch December 30, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants