-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review PR of Develop to Master for CoreMembers Group #12
Open
benjaminbollen
wants to merge
116
commits into
master
Choose a base branch
from
develop
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…usts from backing humans
…ht figured out a more elegant solution using transient storage; will correct
…or-ces merging this as internal history bookkeeping 20250127 core members group for ces
20250129 redemption handler
(LBP): make 1 USD and 10 USD active LBP Condition; deploy 10USD condi…
…h-mixing 20250207 reclean after branch mixing
fix (CRC-615): remove `dataHash` checks and update the `beforeRedeemPolicy` modifier
Basic group mint/redemption test framework utilizing simple flow matrix generator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
careful, in the scripts there might still be references to "CES" or "Supergroup", but in
/src
there should only be concepts relevant forCoreMembers Group
(with the exception oferrors.sol
still having many unused errors that need cleaning out)