Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do as find-function-search-for-symbol does #415

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dickmao
Copy link

@dickmao dickmao commented Jan 26, 2023

The advised function calls find-library-name on library. Not following suit in the advice causes non-existent files to be opened.

The advised function calls find-library-name on library.
Not following suit in the advice causes non-existent files to be opened.
Copy link

@basil-conto basil-conto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If #408 and #413 are addressed (i.e. if hydra.git and elpa.git are brought back in sync), then this PR should no longer be needed.

(with-current-buffer (find-file-noselect library)
(with-current-buffer (find-file-noselect (find-library-name library))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be

(with-current-buffer (car ad-return-value) ...)

instead?

See #413 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants