-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WEB-3364] Storybook migration: remove Rails, setup GH Pages deployment #321
Conversation
661400a
to
798f94c
Compare
798f94c
to
1375a70
Compare
1375a70
to
335911e
Compare
e8ab911
to
feb0c88
Compare
73eab69
to
4f70db7
Compare
e0dbaa1
to
df8db05
Compare
4f70db7
to
ee2bb38
Compare
ee2bb38
to
21386bc
Compare
21386bc
to
fc556a7
Compare
c5eb3f6
to
d4a3e71
Compare
d4a3e71
to
bd863be
Compare
bd863be
to
02e4f39
Compare
@@ -8,121 +8,121 @@ | |||
* - Please do NOT serve this file on production. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All changes here due to linting requirements
@@ -1,28 +1,21 @@ | |||
Jira Ticket Link / Motivation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All changes here due to linting requirements
@@ -5,58 +5,132 @@ import Icon from "../core/Icon/component.jsx"; | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All changes here due to linting requirements
What I have here works and I feel I've chopped as deeply as I'm able to, but given that the criteria I have visibility over is mainly "does Storybook still work", I need some guidance on what happens regarding package deployment @kennethkalmer. I think this should work as I've not fundamentally touched anything there, but so much has been knifed I'm not 100%. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @jamiehenson! well done on being well on your way to having a total net-negative contribution 🤣🎖️
@@ -2,9 +2,6 @@ | |||
"buildpacks": [ | |||
{ | |||
"url": "https://github.com/timanovsky/subdir-heroku-buildpack" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We won't need the subdir buildpack either since this was how we deployed I see storybook outputs to preview
on Heroku review appspreview
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work @jamiehenson, truly remarkable
Jira Ticket Link / Motivation
This PR is 4 of 6 when it comes to the Storybook migration. With #302, we now have a functioning Storybook integration for our Ably UI assets. This PR is all about gutting out all the old Rails assets that are no longer used, and providing a cleaner way of deploying the new assets - in this case, using Github Actions to deploy the static Storybook site to Github Pages.
Jira link: https://ably.atlassian.net/browse/WEB-3364
After this is a TSX rewrite of the Ably UI JSX components, and an investigation into swapping out Webpack as the build tool in favour of Vite.
Summary of changes
How do you manually test this?
Pull it down, get the latest packages, make sure Storybook still runs. Upon release, we'll see whether the deployment works correctly (note: I tested this exact deployment on branch push, and it worked - deploying successfully to https://ably.github.io/ably-ui.
Reviewer Tasks (optional)
Merge/Deploy Checklist
Frontend Checklist