Add a link to the GitHub job in observability server upload #1845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
staging/pull/1845/features
github-actions
bot
temporarily deployed
to
staging/pull/1845/jazzydoc
Currently, the observability server UI links to the workflow run attempt that the upload corresponds to. This is fine in the case where the workflow only contains a single job, as it currently does in ably-cocoa. But in the case where there’s more than one job in a workflow (e.g. in the case of a matrix build, which we intend to switch ably-cocoa to using in #1311), there’s no way to tell which job an upload corresponds to. So, include this information in the upload. Copied from test-observability-action commit d4d651c.
lawrence-forooghian
force-pushed
the
upload-job-url
branch
from
c44cea5
to
d7e7736
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the observability server UI links to the workflow run attempt that the upload corresponds to. This is fine in the case where the workflow only contains a single job, as it currently does in ably-cocoa. But in the case where there’s more than one job in a workflow (e.g. in the case of a matrix build, which we intend to switch ably-cocoa to using in #1311), there’s no way to tell which job an upload corresponds to. So, include this information in the upload.
Copied from ably/test-observability-action@d4d651c.