Fix for "test__090__RestClient__request_…"

[maratal]

Partially addresses #1796

In a test suite this failure goes as test__092__RestClient__request__method_signature_and_arguments__should_do_a_request_and_receive_a_valid_response, i.e. the test which is being executed at the moment when fail("Completion closure should not be called") is called within test__090__RestClient__... test.

Test passes frequently on CI because I assume tests failures after execution not always tracked by XCTest framework. Locally it crashes with this:

*** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Attempted to report a test failure to XCTest while no test case was running. The failure was:
"Completion closure should not be called".

The path "new feature" is not an invalid path, since it's being replaced with "new%20feature" in Foundation. Also this check has nothing to do with a whitespace in the middle. So I'm removing this expectation.

I've noticed that this test fails frequently when other well known set of tests don't fail. So when I've fixed it in this experimental PR, iOS 17 job finally could pass (after a few attemts).

[lawrence-forooghian]

The path "new feature" is not an invalid path, since it's being replaced with "new%20feature" in Foundation.

This is due to the behaviour change in iOS 17 explained here:

For apps linked on or after iOS 17 and aligned OS versions, NSURL parsing has updated from the obsolete RFC 1738/1808 parsing to the same RFC 3986 parsing as NSURLComponents. This unifies the parsing behaviors of the NSURL and NSURLComponents APIs. Now, NSURL automatically percent- and IDNA-encodes invalid characters to help create a valid URL.

[lawrence-forooghian]

I suggest adding a comment here to explain that this error is not possible on iOS 17 and above due to the behaviour I explained above, so that people who see this code understand why we don't have a test for it.