[SDK-3644] Preparation for macOS 13 #1801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thout framework prefix [Xcode 15].
…OBJC_CLASS_$_NSError". This `try/catch` block here is useless, just passing error further [Xcode 15].
This was referenced Sep 15, 2023
lawrence-forooghian
approved these changes
Sep 19, 2023
This was referenced Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1765, #1766
This contains changes required by Xcode 14.3 (and 15 by the means of 64967fe and 62fb233), but not actually switching to macOS 13 for it (Xcode 14.2 accepts those changes just fine).
By switching to macOS 13 explicitly, known set of tests begins to fail on CI, until
ttltimeout for those tests increase (#1783, run). On iOS 17 they at least failed once even with increased timeout. Those tests succeed when run locally (on Xcode 14.3/15).See also PR for adding iOS 17 Ci job.
Other experiments on transition to macOS 13: #1760, #1783, #1797, #1799, #1800